@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't consider empty inlines when considering whether a revision has draft comments or not
Summary: Ref T13513. When computing whether a revision has draft comments or not, ignore empty inlines.
Test Plan: Added empty inlines to a revision, no longer saw a yellow "draft" bubble in the list UI.
Maniphest Tasks: T13513
Differential Revision: https://secure.phabricator.com/D21215
+10
-1
+10
-1
src/applications/differential/query/DifferentialTransactionQuery.php
+10
-1
src/applications/differential/query/DifferentialTransactionQuery.php
···
11
11
PhabricatorUser $viewer,
12
12
DifferentialRevision $revision) {
13
13
14
-
return id(new DifferentialDiffInlineCommentQuery())
14
+
$inlines = id(new DifferentialDiffInlineCommentQuery())
15
15
->setViewer($viewer)
16
16
->withRevisionPHIDs(array($revision->getPHID()))
17
17
->withAuthorPHIDs(array($viewer->getPHID()))
···
19
19
->withIsDeleted(false)
20
20
->needReplyToComments(true)
21
21
->execute();
22
+
23
+
// Don't count empty inlines when considering draft state.
24
+
foreach ($inlines as $key => $inline) {
25
+
if ($inline->isEmptyInlineComment()) {
26
+
unset($inlines[$key]);
27
+
}
28
+
}
29
+
30
+
return $inlines;
22
31
}
23
32
24
33
}