@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use some more human-readable Conduit keys in updated API methods
Summary:
Ref T12074. This uses more consistent Conduit keys for constraint names.
This is a minor compatibility break on watchers/members but since these methods are more useful now this is probably a good time to try to get away with it, and a more consistent API is better in the long run. I need to issue compatibility guidance for the milestones thing anyway and that one isn't avoidable, so try to rip the bandage off all in one go.
Test Plan: Reviewed new constraint names from console, called methods using them.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12074
Differential Revision: https://secure.phabricator.com/D17161
+5
+1
src/applications/project/query/PhabricatorProjectColumnSearchEngine.php
+1
src/applications/project/query/PhabricatorProjectColumnSearchEngine.php
+4
src/applications/project/query/PhabricatorProjectSearchEngine.php
+4
src/applications/project/query/PhabricatorProjectSearchEngine.php
···
24
24
id(new PhabricatorUsersSearchField())
25
25
->setLabel(pht('Members'))
26
26
->setKey('memberPHIDs')
27
+
->setConduitKey('members')
27
28
->setAliases(array('member', 'members')),
28
29
id(new PhabricatorUsersSearchField())
29
30
->setLabel(pht('Watchers'))
30
31
->setKey('watcherPHIDs')
32
+
->setConduitKey('watchers')
31
33
->setAliases(array('watcher', 'watchers')),
32
34
id(new PhabricatorSearchSelectField())
33
35
->setLabel(pht('Status'))
···
55
57
id(new PhabricatorPHIDsSearchField())
56
58
->setLabel(pht('Parent Projects'))
57
59
->setKey('parentPHIDs')
60
+
->setConduitKey('parents')
58
61
->setAliases(array('parent', 'parents', 'parentPHID'))
59
62
->setDescription(pht('Find direct subprojects of specified parents.')),
60
63
id(new PhabricatorPHIDsSearchField())
61
64
->setLabel(pht('Ancestor Projects'))
62
65
->setKey('ancestorPHIDs')
66
+
->setConduitKey('ancestors')
63
67
->setAliases(array('ancestor', 'ancestors', 'ancestorPHID'))
64
68
->setDescription(
65
69
pht('Find all subprojects beneath specified ancestors.')),