@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Conpherence - fix a bug where users have no events
Summary: Fixes T8518. Defaulting $events to null creates carnage further down the stack. Instead, default it to array() so foreach, array_select_keys, etc. don't barf.
Test Plan: logic and will ask the reporting user to verify since they can repro 100%
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T8518
Differential Revision: https://secure.phabricator.com/D13314
+1
-2
+1
-2
src/applications/conpherence/query/ConpherenceThreadQuery.php
+1
-2
src/applications/conpherence/query/ConpherenceThreadQuery.php
···
355
355
$start_epoch = $epochs['start_epoch'];
356
356
$end_epoch = $epochs['end_epoch'];
357
357
358
+
$events = array();
358
359
if ($participant_phids) {
359
360
$events = id(new PhabricatorCalendarEventQuery())
360
361
->setViewer($this->getViewer())
···
363
364
->withDateRange($start_epoch, $end_epoch)
364
365
->execute();
365
366
$events = mpull($events, null, 'getPHID');
366
-
} else {
367
-
$events = null;
368
367
}
369
368
370
369
$invitees = array();