recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a stray qsprintf() in the Herald rules engine when recording rule application to objects

Summary: Ref T13217. See PHI1006.

Test Plan: Touched an object with associated Herald rules.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13217

Differential Revision: https://secure.phabricator.com/D19872

epriestley 2814d340 265f1f9c

+2 -2
+2 -2
src/applications/herald/engine/HeraldEngine.php
··· 243 243 } 244 244 queryfx( 245 245 $conn_w, 246 - 'INSERT IGNORE INTO %T (phid, ruleID) VALUES %Q', 246 + 'INSERT IGNORE INTO %T (phid, ruleID) VALUES %LQ', 247 247 HeraldRule::TABLE_RULE_APPLIED, 248 - implode(', ', $sql)); 248 + $sql); 249 249 } 250 250 } 251 251 }