+9 -9

src/__phutil_library_map__.php

reviewed

··· 92 92 'AphrontView' => 'view/AphrontView.php', 93 93 'AphrontWebpageResponse' => 'aphront/response/AphrontWebpageResponse.php', 94 94 'AuditActionMenuEventListener' => 'applications/audit/events/AuditActionMenuEventListener.php', 95 95 - 'BuildStepImplementation' => 'applications/harbormaster/step/BuildStepImplementation.php', 96 95 'CalendarColors' => 'applications/calendar/constants/CalendarColors.php', 97 96 'CalendarConstants' => 'applications/calendar/constants/CalendarConstants.php', 98 97 'CalendarTimeUtil' => 'applications/calendar/util/CalendarTimeUtil.php', ··· 715 714 'HarbormasterBuildStepCoreCustomField' => 'applications/harbormaster/customfield/HarbormasterBuildStepCoreCustomField.php', 716 715 'HarbormasterBuildStepCustomField' => 'applications/harbormaster/customfield/HarbormasterBuildStepCustomField.php', 717 716 'HarbormasterBuildStepEditor' => 'applications/harbormaster/editor/HarbormasterBuildStepEditor.php', 717 717 + 'HarbormasterBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterBuildStepImplementation.php', 718 718 'HarbormasterBuildStepQuery' => 'applications/harbormaster/query/HarbormasterBuildStepQuery.php', 719 719 'HarbormasterBuildStepTransaction' => 'applications/harbormaster/storage/configuration/HarbormasterBuildStepTransaction.php', 720 720 'HarbormasterBuildStepTransactionQuery' => 'applications/harbormaster/query/HarbormasterBuildStepTransactionQuery.php', ··· 2663 2663 'CelerityResourceGraph' => 'AbstractDirectedGraph', 2664 2664 'CelerityResourceTransformerTestCase' => 'PhabricatorTestCase', 2665 2665 'CelerityResourcesOnDisk' => 'CelerityPhysicalResources', 2666 2666 - 'CommandBuildStepImplementation' => 'BuildStepImplementation', 2666 2666 + 'CommandBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 2667 2667 'ConduitAPIMethod' => 2668 2668 array( 2669 2669 0 => 'Phobject', ··· 3353 3353 'HarbormasterCapabilityManagePlans' => 'PhabricatorPolicyCapability', 3354 3354 'HarbormasterController' => 'PhabricatorController', 3355 3355 'HarbormasterDAO' => 'PhabricatorLiskDAO', 3356 3356 - 'HarbormasterHTTPRequestBuildStepImplementation' => 'BuildStepImplementation', 3356 3356 + 'HarbormasterHTTPRequestBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3357 3357 'HarbormasterManagementBuildWorkflow' => 'HarbormasterManagementWorkflow', 3358 3358 'HarbormasterManagementWorkflow' => 'PhabricatorManagementWorkflow', 3359 3359 'HarbormasterObject' => 'HarbormasterDAO', ··· 3381 3381 'HarbormasterStepDeleteController' => 'HarbormasterController', 3382 3382 'HarbormasterStepEditController' => 'HarbormasterController', 3383 3383 'HarbormasterTargetWorker' => 'HarbormasterWorker', 3384 3384 - 'HarbormasterThrowExceptionBuildStep' => 'BuildStepImplementation', 3384 3384 + 'HarbormasterThrowExceptionBuildStep' => 'HarbormasterBuildStepImplementation', 3385 3385 'HarbormasterUIEventListener' => 'PhabricatorEventListener', 3386 3386 'HarbormasterWorker' => 'PhabricatorWorker', 3387 3387 'HeraldAction' => 'HeraldDAO', ··· 3448 3448 'JavelinUIExample' => 'PhabricatorUIExample', 3449 3449 'JavelinViewExample' => 'PhabricatorUIExample', 3450 3450 'JavelinViewExampleServerView' => 'AphrontView', 3451 3451 - 'LeaseHostBuildStepImplementation' => 'BuildStepImplementation', 3451 3451 + 'LeaseHostBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 3452 3452 'LegalpadCapabilityDefaultEdit' => 'PhabricatorPolicyCapability', 3453 3453 'LegalpadCapabilityDefaultView' => 'PhabricatorPolicyCapability', 3454 3454 'LegalpadController' => 'PhabricatorController', ··· 5398 5398 'PonderVoteSaveController' => 'PonderController', 5399 5399 'ProjectCapabilityCreateProjects' => 'PhabricatorPolicyCapability', 5400 5400 'ProjectRemarkupRule' => 'PhabricatorRemarkupRuleObject', 5401 5401 - 'PublishFragmentBuildStepImplementation' => 'BuildStepImplementation', 5401 5401 + 'PublishFragmentBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5402 5402 'QueryFormattingTestCase' => 'PhabricatorTestCase', 5403 5403 'ReleephAuthorFieldSpecification' => 'ReleephFieldSpecification', 5404 5404 'ReleephBranch' => ··· 5502 5502 'ReleephSummaryFieldSpecification' => 'ReleephFieldSpecification', 5503 5503 'ReleephUserView' => 'AphrontView', 5504 5504 'ShellLogView' => 'AphrontView', 5505 5505 - 'SleepBuildStepImplementation' => 'BuildStepImplementation', 5505 5505 + 'SleepBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5506 5506 'SlowvoteEmbedView' => 'AphrontView', 5507 5507 'SlowvoteRemarkupRule' => 'PhabricatorRemarkupRuleObject', 5508 5508 - 'UploadArtifactBuildStepImplementation' => 'BuildStepImplementation', 5509 5509 - 'WaitForPreviousBuildStepImplementation' => 'BuildStepImplementation', 5508 5508 + 'UploadArtifactBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5509 5509 + 'WaitForPreviousBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 5510 5510 ), 5511 5511 ));

+5 -4

src/applications/harbormaster/controller/HarbormasterPlanViewController.php

reviewed

··· 164 164 165 165 $has_conflicts = false; 166 166 if ($inputs || $outputs) { 167 167 - $available_artifacts = BuildStepImplementation::loadAvailableArtifacts( 168 168 - $plan, 169 169 - $step, 170 170 - null); 167 167 + $available_artifacts = 168 168 + HarbormasterBuildStepImplementation::loadAvailableArtifacts( 169 169 + $plan, 170 170 + $step, 171 171 + null); 171 172 172 173 list($inputs_ui, $has_conflicts) = $this->buildArtifactList( 173 174 $inputs,

+2 -1

src/applications/harbormaster/controller/HarbormasterStepAddController.php

reviewed

··· 26 26 throw new Exception("Build plan not found!"); 27 27 } 28 28 29 29 - $implementations = BuildStepImplementation::getImplementations(); 29 29 + $implementations = 30 30 + HarbormasterBuildStepImplementation::getImplementations(); 30 31 31 32 $cancel_uri = $this->getApplicationURI('plan/'.$plan->getID().'/'); 32 33

+2 -2

src/applications/harbormaster/step/BuildStepImplementation.php src/applications/harbormaster/step/HarbormasterBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 - abstract class BuildStepImplementation { 3 3 + abstract class HarbormasterBuildStepImplementation { 4 4 5 5 public static function getImplementations() { 6 6 $symbols = id(new PhutilSymbolLoader()) 7 7 - ->setAncestorClass('BuildStepImplementation') 7 7 + ->setAncestorClass('HarbormasterBuildStepImplementation') 8 8 ->setConcreteOnly(true) 9 9 ->selectAndLoadSymbols(); 10 10 return ipull($symbols, 'name');

+1 -1

src/applications/harbormaster/step/CommandBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 final class CommandBuildStepImplementation 4 4 - extends BuildStepImplementation { 4 4 + extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() { 7 7 return pht('Run Command');

+1 -1

src/applications/harbormaster/step/HarbormasterHTTPRequestBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 final class HarbormasterHTTPRequestBuildStepImplementation 4 4 - extends BuildStepImplementation { 4 4 + extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() { 7 7 return pht('Make HTTP Request');

+1 -1

src/applications/harbormaster/step/HarbormasterThrowExceptionBuildStep.php

reviewed

··· 1 1 <?php 2 2 3 3 final class HarbormasterThrowExceptionBuildStep 4 4 - extends BuildStepImplementation { 4 4 + extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() { 7 7 return pht('Throw Exception');

+1 -1

src/applications/harbormaster/step/LeaseHostBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 final class LeaseHostBuildStepImplementation 4 4 - extends BuildStepImplementation { 4 4 + extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() { 7 7 return pht('Lease Host');

+1 -1

src/applications/harbormaster/step/PublishFragmentBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 final class PublishFragmentBuildStepImplementation 4 4 - extends BuildStepImplementation { 4 4 + extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() { 7 7 return pht('Publish Fragment');

+2 -1

src/applications/harbormaster/step/SleepBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 - final class SleepBuildStepImplementation extends BuildStepImplementation { 3 3 + final class SleepBuildStepImplementation 4 4 + extends HarbormasterBuildStepImplementation { 4 5 5 6 public function getName() { 6 7 return pht('Sleep');

+1 -1

src/applications/harbormaster/step/UploadArtifactBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 final class UploadArtifactBuildStepImplementation 4 4 - extends BuildStepImplementation { 4 4 + extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() { 7 7 return pht('Upload Artifact');

+1 -1

src/applications/harbormaster/step/WaitForPreviousBuildStepImplementation.php

reviewed

··· 1 1 <?php 2 2 3 3 final class WaitForPreviousBuildStepImplementation 4 4 - extends BuildStepImplementation { 4 4 + extends HarbormasterBuildStepImplementation { 5 5 6 6 public function getName() { 7 7 return pht('Wait for Previous Commits to Build');

+2 -1

src/applications/harbormaster/storage/build/HarbormasterBuildTarget.php

reviewed

··· 88 88 89 89 static $implementations = null; 90 90 if ($implementations === null) { 91 91 - $implementations = BuildStepImplementation::getImplementations(); 91 91 + $implementations = 92 92 + HarbormasterBuildStepImplementation::getImplementations(); 92 93 } 93 94 94 95 $class = $this->className;

+2 -1

src/applications/harbormaster/storage/configuration/HarbormasterBuildStep.php

reviewed

··· 52 52 53 53 static $implementations = null; 54 54 if ($implementations === null) { 55 55 - $implementations = BuildStepImplementation::getImplementations(); 55 55 + $implementations = 56 56 + HarbormasterBuildStepImplementation::getImplementations(); 56 57 } 57 58 58 59 $class = $this->className;