recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove all setObjectURI() from ActionListViews

Summary:
Ref T10004. After D14804, we get this behavior by default and no longer need to set it explicitly.

(If some endpoint did eventually need to set it explicitly, it could just change what it passes to `setHref()`, but I believe we currently have no such endpoints and do not foresee ever having any.)

Test Plan:
- As a logged out user, clicked various links in Differential, Maniphest, Files, etc., always got redirected to a sensible place after login.
- Grepped for `setObjectURI()`, `getObjectURI()` (there are a few remaining callsites, but to a different method with the same name in Doorkeeper).

Reviewers: chad

Reviewed By: chad

Subscribers: hach-que

Maniphest Tasks: T10004

Differential Revision: https://secure.phabricator.com/D14805

epriestley 2868a69f e869e7df

+22 -111
-1
src/applications/calendar/controller/PhabricatorCalendarEventViewController.php
··· 152 152 $is_attending = $event->getIsUserAttending($viewer->getPHID()); 153 153 154 154 $actions = id(new PhabricatorActionListView()) 155 - ->setObjectURI($this->getApplicationURI('event/'.$id.'/')) 156 155 ->setUser($viewer) 157 156 ->setObject($event); 158 157
-1
src/applications/dashboard/controller/PhabricatorDashboardManageController.php
··· 99 99 $id = $dashboard->getID(); 100 100 101 101 $actions = id(new PhabricatorActionListView()) 102 - ->setObjectURI($this->getApplicationURI('view/'.$dashboard->getID().'/')) 103 102 ->setObject($dashboard) 104 103 ->setUser($viewer); 105 104
-1
src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php
··· 84 84 $id = $panel->getID(); 85 85 86 86 $actions = id(new PhabricatorActionListView()) 87 - ->setObjectURI('/'.$panel->getMonogram()) 88 87 ->setObject($panel) 89 88 ->setUser($viewer); 90 89
+1 -2
src/applications/differential/view/DifferentialRevisionDetailView.php
··· 63 63 64 64 $actions = id(new PhabricatorActionListView()) 65 65 ->setUser($user) 66 - ->setObject($revision) 67 - ->setObjectURI($this->getURI()); 66 + ->setObject($revision); 68 67 foreach ($this->getActions() as $action) { 69 68 $actions->addAction($action); 70 69 }
+1 -2
src/applications/diffusion/controller/DiffusionCommitController.php
··· 903 903 904 904 $actions = id(new PhabricatorActionListView()) 905 905 ->setUser($user) 906 - ->setObject($commit) 907 - ->setObjectURI($request->getRequestURI()); 906 + ->setObject($commit); 908 907 909 908 $can_edit = PhabricatorPolicyFilter::hasCapability( 910 909 $user,
+1 -3
src/applications/diffusion/controller/DiffusionRepositoryController.php
··· 480 480 private function buildActionList(PhabricatorRepository $repository) { 481 481 $viewer = $this->getRequest()->getUser(); 482 482 483 - $view_uri = $this->getApplicationURI($repository->getCallsign().'/'); 484 483 $edit_uri = $this->getApplicationURI($repository->getCallsign().'/edit/'); 485 484 486 485 $view = id(new PhabricatorActionListView()) 487 486 ->setUser($viewer) 488 - ->setObject($repository) 489 - ->setObjectURI($view_uri); 487 + ->setObject($repository); 490 488 491 489 $can_edit = PhabricatorPolicyFilter::hasCapability( 492 490 $viewer,
-13
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
··· 224 224 $viewer = $this->getRequest()->getUser(); 225 225 226 226 $view = id(new PhabricatorActionListView()) 227 - ->setObjectURI($this->getRequest()->getRequestURI()) 228 227 ->setUser($viewer); 229 228 230 229 $edit = id(new PhabricatorActionView()) ··· 327 326 $viewer = $this->getRequest()->getUser(); 328 327 329 328 $view = id(new PhabricatorActionListView()) 330 - ->setObjectURI($this->getRequest()->getRequestURI()) 331 329 ->setUser($viewer); 332 330 333 331 $edit = id(new PhabricatorActionView()) ··· 364 362 $viewer = $this->getRequest()->getUser(); 365 363 366 364 $view = id(new PhabricatorActionListView()) 367 - ->setObjectURI($this->getRequest()->getRequestURI()) 368 365 ->setUser($viewer); 369 366 370 367 $edit = id(new PhabricatorActionView()) ··· 419 416 $viewer = $this->getRequest()->getUser(); 420 417 421 418 $view = id(new PhabricatorActionListView()) 422 - ->setObjectURI($this->getRequest()->getRequestURI()) 423 419 ->setUser($viewer); 424 420 425 421 $edit = id(new PhabricatorActionView()) ··· 469 465 $viewer = $this->getRequest()->getUser(); 470 466 471 467 $view = id(new PhabricatorActionListView()) 472 - ->setObjectURI($this->getRequest()->getRequestURI()) 473 468 ->setUser($viewer); 474 469 475 470 $edit = id(new PhabricatorActionView()) ··· 509 504 $viewer = $this->getRequest()->getUser(); 510 505 511 506 $view = id(new PhabricatorActionListView()) 512 - ->setObjectURI($this->getRequest()->getRequestURI()) 513 507 ->setUser($viewer); 514 508 515 509 $edit = id(new PhabricatorActionView()) ··· 551 545 $viewer = $this->getRequest()->getUser(); 552 546 553 547 $view = id(new PhabricatorActionListView()) 554 - ->setObjectURI($this->getRequest()->getRequestURI()) 555 548 ->setUser($viewer); 556 549 557 550 $edit = id(new PhabricatorActionView()) ··· 592 585 $viewer = $this->getRequest()->getUser(); 593 586 594 587 $view = id(new PhabricatorActionListView()) 595 - ->setObjectURI($this->getRequest()->getRequestURI()) 596 588 ->setUser($viewer); 597 589 598 590 $edit = id(new PhabricatorActionView()) ··· 640 632 $viewer = $this->getViewer(); 641 633 642 634 $view = id(new PhabricatorActionListView()) 643 - ->setObjectURI($this->getRequest()->getRequestURI()) 644 635 ->setUser($viewer); 645 636 646 637 $edit = id(new PhabricatorActionView()) ··· 678 669 $viewer = $this->getViewer(); 679 670 680 671 $view = id(new PhabricatorActionListView()) 681 - ->setObjectURI($this->getRequest()->getRequestURI()) 682 672 ->setUser($viewer); 683 673 684 674 $edit = id(new PhabricatorActionView()) ··· 732 722 $user = $this->getRequest()->getUser(); 733 723 734 724 $view = id(new PhabricatorActionListView()) 735 - ->setObjectURI($this->getRequest()->getRequestURI()) 736 725 ->setUser($user); 737 726 738 727 $edit = id(new PhabricatorActionView()) ··· 1240 1229 $viewer = $this->getRequest()->getUser(); 1241 1230 1242 1231 $mirror_actions = id(new PhabricatorActionListView()) 1243 - ->setObjectURI($this->getRequest()->getRequestURI()) 1244 1232 ->setUser($viewer); 1245 1233 1246 1234 $new_mirror_uri = $this->getRepositoryControllerURI( ··· 1319 1307 $viewer = $this->getRequest()->getUser(); 1320 1308 1321 1309 $view = id(new PhabricatorActionListView()) 1322 - ->setObjectURI($this->getRequest()->getRequestURI()) 1323 1310 ->setUser($viewer); 1324 1311 1325 1312 $edit = id(new PhabricatorActionView())
+1 -2
src/applications/diviner/controller/DivinerBookController.php
··· 125 125 126 126 $action_view = id(new PhabricatorActionListView()) 127 127 ->setUser($user) 128 - ->setObject($book) 129 - ->setObjectURI($this->getRequest()->getRequestURI()); 128 + ->setObject($book); 130 129 131 130 $action_view->addAction( 132 131 id(new PhabricatorActionView())
-1
src/applications/drydock/controller/DrydockAuthorizationViewController.php
··· 67 67 68 68 $view = id(new PhabricatorActionListView()) 69 69 ->setUser($viewer) 70 - ->setObjectURI($this->getRequest()->getRequestURI()) 71 70 ->setObject($authorization); 72 71 73 72 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/drydock/controller/DrydockBlueprintViewController.php
··· 86 86 87 87 $view = id(new PhabricatorActionListView()) 88 88 ->setUser($viewer) 89 - ->setObjectURI($this->getRequest()->getRequestURI()) 90 89 ->setObject($blueprint); 91 90 92 91 $edit_uri = $this->getApplicationURI("blueprint/edit/{$id}/");
-1
src/applications/drydock/controller/DrydockLeaseViewController.php
··· 66 66 67 67 $view = id(new PhabricatorActionListView()) 68 68 ->setUser($viewer) 69 - ->setObjectURI($this->getRequest()->getRequestURI()) 70 69 ->setObject($lease); 71 70 72 71 $id = $lease->getID();
-1
src/applications/drydock/controller/DrydockRepositoryOperationViewController.php
··· 68 68 69 69 $view = id(new PhabricatorActionListView()) 70 70 ->setUser($viewer) 71 - ->setObjectURI($this->getRequest()->getRequestURI()) 72 71 ->setObject($operation); 73 72 74 73 return $view;
-1
src/applications/drydock/controller/DrydockResourceViewController.php
··· 74 74 75 75 $view = id(new PhabricatorActionListView()) 76 76 ->setUser($viewer) 77 - ->setObjectURI($this->getRequest()->getRequestURI()) 78 77 ->setObject($resource); 79 78 80 79 $can_release = $resource->canRelease();
-1
src/applications/files/controller/PhabricatorFileInfoController.php
··· 120 120 121 121 $view = id(new PhabricatorActionListView()) 122 122 ->setUser($viewer) 123 - ->setObjectURI($this->getRequest()->getRequestURI()) 124 123 ->setObject($file); 125 124 126 125 $can_download = !$file->getIsPartial();
+1 -2
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
··· 445 445 446 446 $list = id(new PhabricatorActionListView()) 447 447 ->setUser($viewer) 448 - ->setObject($build) 449 - ->setObjectURI("/build/{$id}"); 448 + ->setObject($build); 450 449 451 450 $can_restart = $build->canRestartBuild(); 452 451 $can_pause = $build->canPauseBuild();
+1 -2
src/applications/harbormaster/controller/HarbormasterBuildableViewController.php
··· 74 74 75 75 $list = id(new PhabricatorActionListView()) 76 76 ->setUser($viewer) 77 - ->setObject($buildable) 78 - ->setObjectURI($buildable->getMonogram()); 77 + ->setObject($buildable); 79 78 80 79 $can_edit = PhabricatorPolicyFilter::hasCapability( 81 80 $viewer,
+1 -2
src/applications/harbormaster/controller/HarbormasterPlanViewController.php
··· 221 221 222 222 $list = id(new PhabricatorActionListView()) 223 223 ->setUser($viewer) 224 - ->setObject($plan) 225 - ->setObjectURI($this->getApplicationURI("plan/{$id}/")); 224 + ->setObject($plan); 226 225 227 226 $can_edit = PhabricatorPolicyFilter::hasCapability( 228 227 $viewer,
+1 -2
src/applications/herald/controller/HeraldRuleViewController.php
··· 67 67 68 68 $view = id(new PhabricatorActionListView()) 69 69 ->setUser($viewer) 70 - ->setObject($rule) 71 - ->setObjectURI('/'.$rule->getMonogram()); 70 + ->setObject($rule); 72 71 73 72 $can_edit = PhabricatorPolicyFilter::hasCapability( 74 73 $viewer,
-1
src/applications/legalpad/controller/LegalpadDocumentManageController.php
··· 98 98 99 99 $actions = id(new PhabricatorActionListView()) 100 100 ->setUser($viewer) 101 - ->setObjectURI($this->getRequest()->getRequestURI()) 102 101 ->setObject($document); 103 102 104 103 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/macro/controller/PhabricatorMacroViewController.php
··· 104 104 $view = id(new PhabricatorActionListView()) 105 105 ->setUser($request->getUser()) 106 106 ->setObject($macro) 107 - ->setObjectURI($request->getRequestURI()) 108 107 ->addAction( 109 108 id(new PhabricatorActionView()) 110 109 ->setName(pht('Edit Macro'))
+1 -2
src/applications/maniphest/controller/ManiphestTaskDetailController.php
··· 136 136 137 137 $view = id(new PhabricatorActionListView()) 138 138 ->setUser($viewer) 139 - ->setObject($task) 140 - ->setObjectURI($this->getRequest()->getRequestURI()); 139 + ->setObject($task); 141 140 142 141 $view->addAction( 143 142 id(new PhabricatorActionView())
+1 -2
src/applications/meta/controller/PhabricatorApplicationDetailViewController.php
··· 135 135 PhabricatorApplication $selected) { 136 136 137 137 $view = id(new PhabricatorActionListView()) 138 - ->setUser($user) 139 - ->setObjectURI($this->getRequest()->getRequestURI()); 138 + ->setUser($user); 140 139 141 140 $can_edit = PhabricatorPolicyFilter::hasCapability( 142 141 $user,
-1
src/applications/nuance/controller/NuanceQueueViewController.php
··· 59 59 $id = $queue->getID(); 60 60 61 61 $actions = id(new PhabricatorActionListView()) 62 - ->setObjectURI($queue->getURI()) 63 62 ->setUser($viewer); 64 63 65 64 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/nuance/controller/NuanceSourceViewController.php
··· 80 80 $id = $source->getID(); 81 81 82 82 $actions = id(new PhabricatorActionListView()) 83 - ->setObjectURI($source->getURI()) 84 83 ->setUser($viewer); 85 84 86 85 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/passphrase/controller/PassphraseCredentialViewController.php
··· 89 89 } 90 90 91 91 $actions = id(new PhabricatorActionListView()) 92 - ->setObjectURI('/K'.$id) 93 92 ->setObject($credential) 94 93 ->setUser($viewer); 95 94
+1 -2
src/applications/paste/controller/PhabricatorPasteViewController.php
··· 131 131 132 132 $action_list = id(new PhabricatorActionListView()) 133 133 ->setUser($viewer) 134 - ->setObject($paste) 135 - ->setObjectURI($this->getRequest()->getRequestURI()); 134 + ->setObject($paste); 136 135 137 136 $action_list->addAction( 138 137 id(new PhabricatorActionView())
-1
src/applications/people/controller/PhabricatorPeopleProfileController.php
··· 43 43 44 44 $actions = id(new PhabricatorActionListView()) 45 45 ->setObject($user) 46 - ->setObjectURI($this->getRequest()->getRequestURI()) 47 46 ->setUser($viewer); 48 47 49 48 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/phame/controller/blog/PhameBlogManageController.php
··· 134 134 private function renderActions(PhameBlog $blog, PhabricatorUser $viewer) { 135 135 $actions = id(new PhabricatorActionListView()) 136 136 ->setObject($blog) 137 - ->setObjectURI($this->getRequest()->getRequestURI()) 138 137 ->setUser($viewer); 139 138 140 139 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/phame/controller/blog/PhameBlogViewController.php
··· 108 108 109 109 $actions = id(new PhabricatorActionListView()) 110 110 ->setObject($blog) 111 - ->setObjectURI($this->getRequest()->getRequestURI()) 112 111 ->setUser($viewer); 113 112 114 113 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/phame/controller/post/PhamePostViewController.php
··· 155 155 156 156 $actions = id(new PhabricatorActionListView()) 157 157 ->setObject($post) 158 - ->setObjectURI($this->getRequest()->getRequestURI()) 159 158 ->setUser($viewer); 160 159 161 160 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/phlux/controller/PhluxViewController.php
··· 28 28 29 29 $actions = id(new PhabricatorActionListView()) 30 30 ->setUser($viewer) 31 - ->setObjectURI($request->getRequestURI()) 32 31 ->setObject($var); 33 32 34 33 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/pholio/controller/PholioMockViewController.php
··· 117 117 118 118 $actions = id(new PhabricatorActionListView()) 119 119 ->setUser($viewer) 120 - ->setObjectURI($this->getRequest()->getRequestURI()) 121 120 ->setObject($mock); 122 121 123 122 $can_edit = PhabricatorPolicyFilter::hasCapability(
-1
src/applications/phortune/controller/PhortuneAccountViewController.php
··· 44 44 45 45 $actions = id(new PhabricatorActionListView()) 46 46 ->setUser($viewer) 47 - ->setObjectURI($request->getRequestURI()) 48 47 ->addAction( 49 48 id(new PhabricatorActionView()) 50 49 ->setName(pht('Edit Account'))
+1 -2
src/applications/phortune/controller/PhortuneProductViewController.php
··· 22 22 $edit_uri = $this->getApplicationURI('product/edit/'.$product->getID().'/'); 23 23 24 24 $actions = id(new PhabricatorActionListView()) 25 - ->setUser($viewer) 26 - ->setObjectURI($request->getRequestURI()); 25 + ->setUser($viewer); 27 26 28 27 $crumbs = $this->buildApplicationCrumbs(); 29 28 $crumbs->addTextCrumb(
+1 -2
src/applications/phortune/controller/PhortuneSubscriptionViewController.php
··· 38 38 ->setHeader($title); 39 39 40 40 $actions = id(new PhabricatorActionListView()) 41 - ->setUser($viewer) 42 - ->setObjectURI($request->getRequestURI()); 41 + ->setUser($viewer); 43 42 44 43 $edit_uri = $subscription->getEditURI(); 45 44
+1 -2
src/applications/phragment/controller/PhragmentController.php
··· 92 92 93 93 $actions = id(new PhabricatorActionListView()) 94 94 ->setUser($viewer) 95 - ->setObject($fragment) 96 - ->setObjectURI($fragment->getURI()); 95 + ->setObject($fragment); 97 96 $actions->addAction( 98 97 id(new PhabricatorActionView()) 99 98 ->setName(pht('Download Fragment'))
+1 -2
src/applications/phragment/controller/PhragmentSnapshotViewController.php
··· 106 106 107 107 $actions = id(new PhabricatorActionListView()) 108 108 ->setUser($viewer) 109 - ->setObject($snapshot) 110 - ->setObjectURI($snapshot->getURI()); 109 + ->setObject($snapshot); 111 110 $actions->addAction( 112 111 id(new PhabricatorActionView()) 113 112 ->setName(pht('Download Snapshot as ZIP'))
+1 -2
src/applications/phragment/controller/PhragmentVersionController.php
··· 51 51 52 52 $actions = id(new PhabricatorActionListView()) 53 53 ->setUser($viewer) 54 - ->setObject($version) 55 - ->setObjectURI($version->getURI()); 54 + ->setObject($version); 56 55 $actions->addAction( 57 56 id(new PhabricatorActionView()) 58 57 ->setName(pht('Download Version'))
-1
src/applications/phriction/controller/PhrictionDocumentController.php
··· 267 267 268 268 $action_view = id(new PhabricatorActionListView()) 269 269 ->setUser($viewer) 270 - ->setObjectURI($this->getRequest()->getRequestURI()) 271 270 ->setObject($document); 272 271 273 272 if (!$document->getID()) {
-1
src/applications/phurl/controller/PhabricatorPhurlURLViewController.php
··· 91 91 $id = $url->getID(); 92 92 93 93 $actions = id(new PhabricatorActionListView()) 94 - ->setObjectURI($url->getURI()) 95 94 ->setUser($viewer) 96 95 ->setObject($url); 97 96
+1 -2
src/applications/ponder/controller/PonderQuestionViewController.php
··· 143 143 144 144 $view = id(new PhabricatorActionListView()) 145 145 ->setUser($viewer) 146 - ->setObject($question) 147 - ->setObjectURI($request->getRequestURI()); 146 + ->setObject($question); 148 147 149 148 $view->addAction( 150 149 id(new PhabricatorActionView())
+1 -2
src/applications/ponder/view/PonderAnswerView.php
··· 168 168 169 169 $view = id(new PhabricatorActionListView()) 170 170 ->setUser($viewer) 171 - ->setObject($answer) 172 - ->setObjectURI('Q'.$answer->getQuestionID()); 171 + ->setObject($answer); 173 172 174 173 $user_marked = $answer->getUserVote(); 175 174 $can_vote = $viewer->isLoggedIn();
-1
src/applications/project/controller/PhabricatorProjectColumnDetailController.php
··· 83 83 $base_uri = '/board/'.$project_id.'/'; 84 84 85 85 $actions = id(new PhabricatorActionListView()) 86 - ->setObjectURI($this->getApplicationURI($base_uri.'column/'.$id.'/')) 87 86 ->setUser($viewer); 88 87 89 88 $can_edit = PhabricatorPolicyFilter::hasCapability(
+1 -2
src/applications/project/controller/PhabricatorProjectProfileController.php
··· 79 79 80 80 $view = id(new PhabricatorActionListView()) 81 81 ->setUser($viewer) 82 - ->setObject($project) 83 - ->setObjectURI($request->getRequestURI()); 82 + ->setObject($project); 84 83 85 84 $can_edit = PhabricatorPolicyFilter::hasCapability( 86 85 $viewer,
+1 -2
src/applications/releeph/controller/branch/ReleephBranchViewController.php
··· 87 87 88 88 $actions = id(new PhabricatorActionListView()) 89 89 ->setUser($viewer) 90 - ->setObject($branch) 91 - ->setObjectURI($this->getRequest()->getRequestURI()); 90 + ->setObject($branch); 92 91 93 92 $can_edit = PhabricatorPolicyFilter::hasCapability( 94 93 $viewer,
+1 -2
src/applications/releeph/controller/product/ReleephProductViewController.php
··· 86 86 87 87 $actions = id(new PhabricatorActionListView()) 88 88 ->setUser($viewer) 89 - ->setObject($product) 90 - ->setObjectURI($this->getRequest()->getRequestURI()); 89 + ->setObject($product); 91 90 92 91 $can_edit = PhabricatorPolicyFilter::hasCapability( 93 92 $viewer,
+1 -2
src/applications/spaces/controller/PhabricatorSpacesViewController.php
··· 102 102 $viewer = $this->getRequest()->getUser(); 103 103 104 104 $list = id(new PhabricatorActionListView()) 105 - ->setUser($viewer) 106 - ->setObjectURI('/'.$space->getMonogram()); 105 + ->setUser($viewer); 107 106 108 107 $can_edit = PhabricatorPolicyFilter::hasCapability( 109 108 $viewer,
-7
src/view/layout/PhabricatorActionListView.php
··· 4 4 5 5 private $actions = array(); 6 6 private $object; 7 - private $objectURI; 8 7 private $id = null; 9 8 10 9 public function setObject(PhabricatorLiskDAO $object) { 11 10 $this->object = $object; 12 - return $this; 13 - } 14 - 15 - public function setObjectURI($uri) { 16 - $this->objectURI = $uri; 17 11 return $this; 18 12 } 19 13 ··· 47 41 } 48 42 49 43 foreach ($actions as $action) { 50 - $action->setObjectURI($this->objectURI); 51 44 $action->setUser($this->user); 52 45 } 53 46
-22
src/view/layout/PhabricatorActionView.php
··· 10 10 private $workflow; 11 11 private $renderAsForm; 12 12 private $download; 13 - private $objectURI; 14 13 private $sigils = array(); 15 14 private $metadata; 16 15 private $selected; ··· 34 33 return $this->metadata; 35 34 } 36 35 37 - public function setObjectURI($object_uri) { 38 - $this->objectURI = $object_uri; 39 - return $this; 40 - } 41 - 42 - public function getObjectURI() { 43 - return $this->objectURI; 44 - } 45 - 46 36 public function setDownload($download) { 47 37 $this->download = $download; 48 38 return $this; ··· 62 52 return $this; 63 53 } 64 54 65 - /** 66 - * If the user is not logged in and the action is relatively complicated, 67 - * give them a generic login link that will re-direct to the page they're 68 - * viewing. 69 - */ 70 55 public function getHref() { 71 - if (($this->workflow || $this->renderAsForm) && !$this->download) { 72 - if (!$this->user || !$this->user->isLoggedIn()) { 73 - return id(new PhutilURI('/auth/start/')) 74 - ->setQueryParam('next', (string)$this->getObjectURI()); 75 - } 76 - } 77 - 78 56 return $this->href; 79 57 } 80 58