recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a couple of other missing getApplicationTransactionCommentObject() implementations

Summary:
See PHI165. See D18715. These objects (projects, blogs) also need implementations now.

(I thought about making this method `abstract` or doing try/catch to maybe make this more robust, but I think this should be the end of it, and those changes have mild complexity/compatibility/risk issues.)

Test Plan: Changed `bin/search index` to index only one document of each type, ran `bin/search index --all --force`, saw no more comment-related errors.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18729

epriestley 28a24c33 1d213dc1

+8
+4
src/applications/phame/storage/PhameBlogTransaction.php
··· 15 15 return PhabricatorPhameBlogPHIDType::TYPECONST; 16 16 } 17 17 18 + public function getApplicationTransactionCommentObject() { 19 + return null; 20 + } 21 + 18 22 public function getBaseTransactionClass() { 19 23 return 'PhameBlogTransactionType'; 20 24 }
+4
src/applications/project/storage/PhabricatorProjectTransaction.php
··· 19 19 return PhabricatorProjectProjectPHIDType::TYPECONST; 20 20 } 21 21 22 + public function getApplicationTransactionCommentObject() { 23 + return null; 24 + } 25 + 22 26 public function getBaseTransactionClass() { 23 27 return 'PhabricatorProjectTransactionType'; 24 28 }