recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Make Phame blog policies non-nullable

Summary: Ref T6203. Ref T13661. These policies are incorrectly nullable, although it's likely that no pathway exists in the application to write NULL into them. Fix the schema.

Test Plan: Ran `bin/storage upgrade`.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13661, T6203

Differential Revision: https://secure.phabricator.com/D21748

epriestley 28b12fb3 dec95228

+12 -4
+5
resources/sql/autopatches/20220401.phameinteract.01.sql
··· 1 + UPDATE {$NAMESPACE}_phame.phame_blog 2 + SET editPolicy = 'admin' WHERE editPolicy IS NULL; 3 + 4 + ALTER TABLE {$NAMESPACE}_phame.phame_blog 5 + CHANGE editPolicy editPolicy VARBINARY(64) NOT NULL;
+5
resources/sql/autopatches/20220401.phameinteract.02.sql
··· 1 + UPDATE {$NAMESPACE}_phame.phame_blog 2 + SET viewPolicy = 'admin' WHERE viewPolicy IS NULL; 3 + 4 + ALTER TABLE {$NAMESPACE}_phame.phame_blog 5 + CHANGE viewPolicy viewPolicy VARBINARY(64) NOT NULL;
+2 -4
src/applications/phame/storage/PhameBlog.php
··· 56 56 'profileImagePHID' => 'phid?', 57 57 'headerImagePHID' => 'phid?', 58 58 59 - // T6203/NULLABILITY 60 - // These policies should always be non-null. 61 - 'editPolicy' => 'policy?', 62 - 'viewPolicy' => 'policy?', 59 + 'editPolicy' => 'policy', 60 + 'viewPolicy' => 'policy', 63 61 ), 64 62 self::CONFIG_KEY_SCHEMA => array( 65 63 'key_phid' => null,