@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add "diffusion.commit.edit", a v3 edit API endpoint for commits
Summary: Ref T10978. This currently does almost nothing, but gets it in place so I can add stuff to it.
Test Plan: Made a comment on a commit using the API.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10978
Differential Revision: https://secure.phabricator.com/D17178
+32
-1
+2
src/__phutil_library_map__.php
+2
src/__phutil_library_map__.php
···
623
623
'DiffusionCommitDiffContentHeraldField' => 'applications/diffusion/herald/DiffusionCommitDiffContentHeraldField.php',
624
624
'DiffusionCommitDiffContentRemovedHeraldField' => 'applications/diffusion/herald/DiffusionCommitDiffContentRemovedHeraldField.php',
625
625
'DiffusionCommitDiffEnormousHeraldField' => 'applications/diffusion/herald/DiffusionCommitDiffEnormousHeraldField.php',
626
+
'DiffusionCommitEditConduitAPIMethod' => 'applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php',
626
627
'DiffusionCommitEditController' => 'applications/diffusion/controller/DiffusionCommitEditController.php',
627
628
'DiffusionCommitEditEngine' => 'applications/diffusion/editor/DiffusionCommitEditEngine.php',
628
629
'DiffusionCommitFulltextEngine' => 'applications/repository/search/DiffusionCommitFulltextEngine.php',
···
5316
5317
'DiffusionCommitDiffContentHeraldField' => 'DiffusionCommitHeraldField',
5317
5318
'DiffusionCommitDiffContentRemovedHeraldField' => 'DiffusionCommitHeraldField',
5318
5319
'DiffusionCommitDiffEnormousHeraldField' => 'DiffusionCommitHeraldField',
5320
+
'DiffusionCommitEditConduitAPIMethod' => 'PhabricatorEditEngineAPIMethod',
5319
5321
'DiffusionCommitEditController' => 'DiffusionController',
5320
5322
'DiffusionCommitEditEngine' => 'PhabricatorEditEngine',
5321
5323
'DiffusionCommitFulltextEngine' => 'PhabricatorFulltextEngine',
+20
src/applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php
+20
src/applications/diffusion/conduit/DiffusionCommitEditConduitAPIMethod.php
···
1
+
<?php
2
+
3
+
final class DiffusionCommitEditConduitAPIMethod
4
+
extends PhabricatorEditEngineAPIMethod {
5
+
6
+
public function getAPIMethodName() {
7
+
return 'diffusion.commit.edit';
8
+
}
9
+
10
+
public function newEditEngine() {
11
+
return new DiffusionCommitEditEngine();
12
+
}
13
+
14
+
public function getMethodSummary() {
15
+
return pht(
16
+
'Apply transactions to edit an existing commit. This method can not '.
17
+
'create new commits.');
18
+
}
19
+
20
+
}
+10
-1
src/applications/diffusion/editor/DiffusionCommitEditEngine.php
+10
-1
src/applications/diffusion/editor/DiffusionCommitEditEngine.php
···
26
26
}
27
27
28
28
protected function newEditableObject() {
29
-
throw new PhutilMethodNotImplementedException();
29
+
// NOTE: We must return a valid object here so that things like Conduit
30
+
// documentation generation work. You can't actually create commits via
31
+
// EditEngine. This is enforced with a "No One" creation policy.
32
+
33
+
$repository = new PhabricatorRepository();
34
+
$data = new PhabricatorRepositoryCommitData();
35
+
36
+
return id(new PhabricatorRepositoryCommit())
37
+
->attachRepository($repository)
38
+
->attachCommitData($data);
30
39
}
31
40
32
41
protected function newObjectQuery() {