@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix margins and spacing of other revision lists
Summary: Fixes spacing in Differential revision detail and Diffusion browse views.
Test Plan:
{F48677}
{F48678}
Reviewers: chad
Reviewed By: chad
CC: aran
Differential Revision: https://secure.phabricator.com/D6359
+17
-15
+4
-5
src/applications/differential/controller/DifferentialRevisionViewController.php
+4
-5
src/applications/differential/controller/DifferentialRevisionViewController.php
···
840
840
$handles = $this->loadViewerHandles($phids);
841
841
$view->setHandles($handles);
842
842
843
-
return hsprintf(
844
-
'%s<div class="differential-panel">%s</div>',
843
+
return array(
845
844
id(new PhabricatorHeaderView())
846
-
->setHeader(pht('Open Revisions Affecting These Files'))
847
-
->render(),
848
-
$view->render());
845
+
->setHeader(pht('Open Revisions Affecting These Files')),
846
+
$view,
847
+
);
849
848
}
850
849
851
850
/**
+7
-5
src/applications/diffusion/controller/DiffusionBrowseController.php
+7
-5
src/applications/diffusion/controller/DiffusionBrowseController.php
···
93
93
$box->setShadow(true);
94
94
$box->appendChild($readme);
95
95
$box->addPadding(PHUI::PADDING_LARGE);
96
+
$box->addMargin(PHUI::MARGIN_LARGE);
96
97
97
-
$panel = new AphrontPanelView();
98
-
$panel->setHeader(pht('README'));
99
-
$panel->setNoBackground();
100
-
$panel->appendChild($box);
98
+
$header = id(new PhabricatorHeaderView())
99
+
->setHeader(pht('README'));
101
100
102
-
$content[] = $panel;
101
+
$content[] = array(
102
+
$header,
103
+
$box,
104
+
);
103
105
}
104
106
105
107
}
+6
-5
src/applications/diffusion/controller/DiffusionController.php
+6
-5
src/applications/diffusion/controller/DiffusionController.php
···
133
133
$handles = $this->loadViewerHandles($phids);
134
134
$view->setHandles($handles);
135
135
136
-
$panel = new AphrontPanelView();
137
-
$panel->setId('pending-differential-revisions');
138
-
$panel->setHeader('Pending Differential Revisions');
139
-
$panel->appendChild($view);
136
+
$header = id(new PhabricatorHeaderView())
137
+
->setHeader(pht('Pending Differential Revisions'));
140
138
141
-
return $panel;
139
+
return array(
140
+
$header,
141
+
$view,
142
+
);
142
143
}
143
144
144
145
private function buildCrumbList(array $spec = array()) {