@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hide build target messages if there are no messages for the target
Summary: Ref T1049. This hides the build target messages area if there are no messages for the target. Since most of the time a build target won't recieve any messages, this area is confusing because it's always empty.
Test Plan: Viewed a build, saw the empty build target message areas disappear.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley, Korvin
Maniphest Tasks: T1049
Differential Revision: https://secure.phabricator.com/D10092
+3
-1
+3
-1
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
+3
-1
src/applications/harbormaster/controller/HarbormasterBuildViewController.php
···
97
97
->addPropertyList($properties);
98
98
99
99
$build_messages = idx($messages, $build_target->getPHID(), array());
100
-
$targets[] = $this->buildMessages($build_messages);
100
+
if ($build_messages) {
101
+
$targets[] = $this->buildMessages($build_messages);
102
+
}
101
103
102
104
$targets[] = $this->buildArtifacts($build_target);
103
105
$targets[] = $this->buildLog($build, $build_target);