@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Diviner to modern UI
Summary: Moves to `newPage`, updates UI on edit page.
Test Plan: Edit a book, view a book, main, list, search.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15585
+36
-32
+4
-6
src/applications/diviner/controller/DivinerAtomController.php
+4
-6
src/applications/diviner/controller/DivinerAtomController.php
···
240
240
241
241
$prop_list = phutil_tag_div('phui-document-view-pro-box', $prop_list);
242
242
243
-
return $this->buildApplicationPage(
244
-
array(
245
-
$crumbs,
243
+
return $this->newPage()
244
+
->setTitle($symbol->getTitle())
245
+
->setCrumbs($crumbs)
246
+
->appendChild(array(
246
247
$document,
247
248
$prop_list,
248
-
),
249
-
array(
250
-
'title' => $symbol->getTitle(),
251
249
));
252
250
}
253
251
+4
-6
src/applications/diviner/controller/DivinerBookController.php
+4
-6
src/applications/diviner/controller/DivinerBookController.php
···
92
92
$document->appendChild($preface_view);
93
93
$document->appendChild($out);
94
94
95
-
return $this->buildApplicationPage(
96
-
array(
97
-
$crumbs,
95
+
return $this->newPage()
96
+
->setTitle($book->getTitle())
97
+
->setCrumbs($crumbs)
98
+
->appendChild(array(
98
99
$document,
99
-
),
100
-
array(
101
-
'title' => $book->getTitle(),
102
100
));
103
101
}
104
102
+19
-10
src/applications/diviner/controller/DivinerBookEditController.php
+19
-10
src/applications/diviner/controller/DivinerBookEditController.php
···
57
57
58
58
$crumbs = $this->buildApplicationCrumbs();
59
59
$crumbs->addTextCrumb(pht('Edit Basics'));
60
+
$crumbs->setBorder(true);
60
61
61
-
$title = pht('Edit %s', $book->getTitle());
62
+
$title = pht('Edit Book: %s', $book->getTitle());
63
+
$header_icon = 'fa-pencil';
62
64
63
65
$policies = id(new PhabricatorPolicyQuery())
64
66
->setViewer($viewer)
···
104
106
->setValue(pht('Save'))
105
107
->addCancelButton($view_uri));
106
108
107
-
$object_box = id(new PHUIObjectBoxView())
108
-
->setHeaderText($title)
109
+
$box = id(new PHUIObjectBoxView())
110
+
->setHeaderText(pht('Book'))
111
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
109
112
->setForm($form);
110
113
111
114
$timeline = $this->buildTransactionTimeline(
···
113
116
new DivinerLiveBookTransactionQuery());
114
117
$timeline->setShouldTerminate(true);
115
118
116
-
return $this->buildApplicationPage(
117
-
array(
118
-
$crumbs,
119
-
$object_box,
119
+
$header = id(new PHUIHeaderView())
120
+
->setHeader($title)
121
+
->setHeaderIcon($header_icon);
122
+
123
+
$view = id(new PHUITwoColumnView())
124
+
->setHeader($header)
125
+
->setFooter(array(
126
+
$box,
120
127
$timeline,
121
-
),
122
-
array(
123
-
'title' => $title,
124
128
));
129
+
130
+
return $this->newPage()
131
+
->setTitle($title)
132
+
->setCrumbs($crumbs)
133
+
->appendChild($view);
125
134
}
126
135
127
136
}
+5
-4
src/applications/diviner/controller/DivinerFindController.php
+5
-4
src/applications/diviner/controller/DivinerFindController.php
···
84
84
85
85
$list = $this->renderAtomList($atoms);
86
86
87
-
return $this->buildApplicationPage(
88
-
$list,
89
-
array(
90
-
'title' => array(pht('Find'), pht('"%s"', $query_text)),
87
+
return $this->newPage()
88
+
->setTitle(array(pht('Find'), pht('"%s"', $query_text)))
89
+
->appendChild(array(
90
+
$list,
91
91
));
92
+
92
93
}
93
94
94
95
}
+4
-6
src/applications/diviner/controller/DivinerMainController.php
+4
-6
src/applications/diviner/controller/DivinerMainController.php
···
65
65
$document->appendChild($text);
66
66
}
67
67
68
-
return $this->buildApplicationPage(
69
-
array(
70
-
$crumbs,
68
+
return $this->newPage()
69
+
->setTitle(pht('Documentation Books'))
70
+
->setCrumbs($crumbs)
71
+
->appendChild(array(
71
72
$document,
72
-
),
73
-
array(
74
-
'title' => pht('Documentation Books'),
75
73
));
76
74
}
77
75
}