@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't let `bin/drydock lease --attributes` overwrite blueprints
Summary:
Depends on D19076. Ref T13073. Blueprints are stored as an attribute and `setAttributes()` overwrites all attributes.
This is sorta junk but make it less obviously broken, at least.
Test Plan: Ran `bin/drydock lease --type working-copy --attributes x=y` without instantly getting a fatal about "no blueprint PHIDs".
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T13073
Differential Revision: https://secure.phabricator.com/D19077
+4
-4
+4
-4
src/applications/drydock/management/DrydockManagementLeaseWorkflow.php
+4
-4
src/applications/drydock/management/DrydockManagementLeaseWorkflow.php
···
62
62
$drydock_phid = id(new PhabricatorDrydockApplication())->getPHID();
63
63
$lease->setAuthorizingPHID($drydock_phid);
64
64
65
+
if ($attributes) {
66
+
$lease->setAttributes($attributes);
67
+
}
68
+
65
69
// TODO: This is not hugely scalable, although this is a debugging workflow
66
70
// so maybe it's fine. Do we even need `bin/drydock lease` in the long run?
67
71
$all_blueprints = id(new DrydockBlueprintQuery())
···
75
79
'satisfy the requested lease.'));
76
80
}
77
81
$lease->setAllowedBlueprintPHIDs($allowed_phids);
78
-
79
-
if ($attributes) {
80
-
$lease->setAttributes($attributes);
81
-
}
82
82
83
83
if ($until) {
84
84
$lease->setUntil($until);