@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix DifferentialRevisionEditor handling of actorPHID after D3645
Summary: `actorPHID` no longer gets set or exists.
Test Plan: Updated a revision without fataling.
Reviewers: btrahan, vrana
Reviewed By: vrana
CC: aran
Differential Revision: https://secure.phabricator.com/D3684
+5
-5
+5
-5
src/applications/differential/editor/DifferentialRevisionEditor.php
+5
-5
src/applications/differential/editor/DifferentialRevisionEditor.php
···
142
142
}
143
143
144
144
protected function getActorPHID() {
145
-
return $this->actorPHID;
145
+
return $this->getActor()->getPHID();
146
146
}
147
147
148
148
public function isNewRevision() {
···
293
293
$this->reviewers,
294
294
array_keys($rem['rev']),
295
295
array_keys($add['rev']),
296
-
$this->actorPHID);
296
+
$this->getActorPHID());
297
297
298
298
// We want to attribute new CCs to a "reasonPHID", representing the reason
299
299
// they were added. This is either a user (if some user explicitly CCs
···
306
306
if (empty($new['ccs'][$phid])) {
307
307
$reasons[$phid] = $xscript_phid;
308
308
} else {
309
-
$reasons[$phid] = $this->actorPHID;
309
+
$reasons[$phid] = $this->getActorPHID();
310
310
}
311
311
}
312
312
foreach ($rem['ccs'] as $phid => $ignored) {
313
313
if (empty($new['ccs'][$phid])) {
314
-
$reasons[$phid] = $this->actorPHID;
314
+
$reasons[$phid] = $this->getActorPHID();
315
315
} else {
316
316
$reasons[$phid] = $xscript_phid;
317
317
}
318
318
}
319
319
} else {
320
-
$reasons = $this->actorPHID;
320
+
$reasons = $this->getActorPHID();
321
321
}
322
322
323
323
self::alterCCs(