@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't treat Quicksand requests as isWorkflow() or isAjax()
Summary:
Fixes T7061. Although it's very simple, I think this is a complete fix.
Quicksand technically is Ajax and uses Workflow as a transport mechanism, but the server should always pretend the user clicked a normal link when rendering.
Test Plan: Links that were autoconverting into dialogs (like "Edit Task") or otherwise making the wrong behavioral choices now work as expected.
Reviewers: btrahan, chad
Reviewed By: chad
Subscribers: epriestley
Maniphest Tasks: T7061
Differential Revision: https://secure.phabricator.com/D12194
+2
-2
+2
-2
src/aphront/AphrontRequest.php
+2
-2
src/aphront/AphrontRequest.php
···
192
192
}
193
193
194
194
final public function isAjax() {
195
-
return $this->getExists(self::TYPE_AJAX);
195
+
return $this->getExists(self::TYPE_AJAX) && !$this->isQuicksand();
196
196
}
197
197
198
198
final public function isWorkflow() {
199
-
return $this->getExists(self::TYPE_WORKFLOW);
199
+
return $this->getExists(self::TYPE_WORKFLOW) && !$this->isQuicksand();
200
200
}
201
201
202
202
final public function isQuicksand() {