@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When authors add inlines to their own revisions/commits, mark them as "Done" by default
Summary:
Ref T13195. Fixes T8573. When you're adding inlines to your own stuff, mark them "Done" by default. You can unmark them as "Done" if you're legitimately leaving TODOs for yourself, although I think this is unusual.
(If this turns out to be less unusual than I think, we could consider an alternate rule: mark replies by the author as "Done" by default.)
Test Plan: Added some inlines as an author and a non-author. Saw my author inlines marked as "Done" by default. Submitted them; unmarked and submittted them.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13195, T8573
Differential Revision: https://secure.phabricator.com/D19635
+9
+9
src/infrastructure/diff/PhabricatorInlineCommentController.php
+9
src/infrastructure/diff/PhabricatorInlineCommentController.php
···
231
231
$inline->setReplyToCommentPHID($this->getReplyToCommentPHID());
232
232
}
233
233
234
+
// If you own this object, mark your own inlines as "Done" by default.
235
+
$owner_phid = $this->loadObjectOwnerPHID($inline);
236
+
if ($owner_phid) {
237
+
if ($viewer->getPHID() == $owner_phid) {
238
+
$fixed_state = PhabricatorInlineCommentInterface::STATE_DRAFT;
239
+
$inline->setFixedState($fixed_state);
240
+
}
241
+
}
242
+
234
243
$this->saveComment($inline);
235
244
236
245
return $this->buildRenderedCommentResponse(