@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Route lipsum writes through the new Maniphest transaction code
Summary: Ref T2217. Ship these through the new stuff.
Test Plan: See screenshot.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2217
Differential Revision: https://secure.phabricator.com/D7087
+9
-5
+9
-5
src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php
+9
-5
src/applications/maniphest/lipsum/PhabricatorManiphestTaskTestDataGenerator.php
···
10
10
$task = id(new ManiphestTask())
11
11
->setSubPriority($this->generateTaskSubPriority())
12
12
->setAuthorPHID($authorPHID)
13
-
->setTitle($this->generateTitle());
13
+
->setTitle($this->generateTitle())
14
+
->setStatus(ManiphestTaskStatus::STATUS_OPEN);
15
+
14
16
$content_source = PhabricatorContentSource::newForSource(
15
17
PhabricatorContentSource::SOURCE_UNKNOWN,
16
18
array());
17
-
$template = id(new ManiphestTransaction())
18
-
->setAuthorPHID($authorPHID)
19
-
->setContentSource($content_source);
19
+
20
+
$template = new ManiphestTransactionPro();
20
21
// Accumulate Transactions
21
22
$changes = array();
22
23
$changes[ManiphestTransactionType::TYPE_TITLE] =
···
42
43
}
43
44
44
45
// Apply Transactions
45
-
$editor = id(new ManiphestTransactionEditor())
46
+
$editor = id(new ManiphestTransactionEditorPro())
46
47
->setActor($author)
48
+
->setContentSource($content_source)
49
+
->setContinueOnNoEffect(true)
50
+
->setContinueOnMissingFields(true)
47
51
->applyTransactions($task, $transactions);
48
52
return $task->save();
49
53
}