@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a PhutilOpaqueEnvelope issue with `bin/storage dump`
Summary: We need to open the envelope here.
Test Plan: Ran `bin/storage dump` without errors.
Reviewers: vrana, btrahan
Reviewed By: vrana
CC: aran
Differential Revision: https://secure.phabricator.com/D3315
+9
-3
+9
-3
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
+9
-3
src/infrastructure/storage/management/workflow/PhabricatorStorageManagementDumpWorkflow.php
···
45
45
46
46
list($host, $port) = $this->getBareHostAndPort($api->getHost());
47
47
48
-
$flag_password = $api->getPassword()
49
-
? csprintf('-p %s', $api->getPassword())
50
-
: '';
48
+
$flag_password = '';
49
+
50
+
$password = $api->getPassword();
51
+
if ($password) {
52
+
$password = $password->openEnvelope();
53
+
if (strlen($password)) {
54
+
$flag_password = csprintf('-p %s', $password);
55
+
}
56
+
}
51
57
52
58
$flag_port = $port
53
59
? csprintf('--port %d', $port)