recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix no-op transaction error on `paste.create` Conduit API method

Summary:
Fixes T9735. I changed how the TYPE_LANGUAGE transction works a little but that accidentally tripped an error condition in `paste.create`.

- Don't bail on no-effect transactions to `paste.create` (like not setting a language).
- When a transaction type has no tailored UI message, make it easier to figure out which transaction is problematic.

Test Plan: Ran `arc paste ...` locally. Got an error before the patch, clean paste creation afterward.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9735

Differential Revision: https://secure.phabricator.com/D14440

epriestley 2b41ed01 c86a514f

+4 -1
+1
src/applications/paste/conduit/PasteCreateConduitAPIMethod.php
··· 60 60 61 61 $editor = id(new PhabricatorPasteEditor()) 62 62 ->setActor($viewer) 63 + ->setContinueOnNoEffect(true) 63 64 ->setContentSourceFromConduitRequest($request); 64 65 65 66 $xactions = $editor->applyTransactions($paste, $xactions);
+3 -1
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
··· 626 626 return pht('Edges already exist; transaction has no effect.'); 627 627 } 628 628 629 - return pht('Transaction has no effect.'); 629 + return pht( 630 + 'Transaction (of type "%s") has no effect.', 631 + $this->getTransactionType()); 630 632 } 631 633 632 634 public function getTitle() {