@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Better 404 for Phame
Summary: "Fixes" fatals on phacility.com blog. If post_id is either `0` or any other integer not in the blog system, show a normal Phame 404 with crumbs.
Test Plan: http://local.blog.phacility.com/post/0/last_published/, http://local.blog.phacility.com/post/999999/last_published/
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D16192
+3
-1
+3
-1
src/applications/phame/controller/PhameLiveController.php
+3
-1
src/applications/phame/controller/PhameLiveController.php
···
87
87
$this->isExternal = $is_external;
88
88
$this->isLive = $is_live;
89
89
90
-
if ($post_id) {
90
+
if (strlen($post_id)) {
91
91
$post_query = id(new PhamePostQuery())
92
92
->setViewer($viewer)
93
93
->withIDs(array($post_id));
···
104
104
105
105
$post = $post_query->executeOne();
106
106
if (!$post) {
107
+
// Not a valid Post
108
+
$this->blog = $blog;
107
109
return new Aphront404Response();
108
110
}
109
111