@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't hang on `/status/` for newer Node
Summary: At some point, Node started requiring us to read data before we can get the 'end' event, it seems. Fixes T2953.
Test Plan: Ran server in `--foreground` mode on node v0.11.0, made request to `/status/`, got response.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Maniphest Tasks: T2953
Differential Revision: https://secure.phabricator.com/D5666
+5
+5
support/aphlict/server/aphlict_server.js
+5
support/aphlict/server/aphlict_server.js
···
182
182
response.end();
183
183
});
184
184
} else if (request.url == '/status/') {
185
+
request.on('data', function(data) {
186
+
// We just ignore the request data, but newer versions of Node don't
187
+
// get to 'end' if we don't process the data. See T2953.
188
+
});
189
+
185
190
request.on('end', function() {
186
191
var status = {
187
192
'uptime': (new Date().getTime() - start_time),