@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Mobile layouts for Diffusion
Summary: Implements a new mobile view thats more fullscreen, not boxed, so more space. Fixes issues with mobile tables when scrolling overflowed content.
Test Plan: Test home, branch, tags, code, file browse, graph, compare, history, readme, open revisions, owners.
Reviewers: epriestley
Reviewed By: epriestley
Spies: Korvin
Differential Revision: https://secure.phabricator.com/D18505
+58
-37
+9
-9
resources/celerity/map.php
+9
-9
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => 'e68cf1fa',
11
11
'conpherence.pkg.js' => 'b5b51108',
12
-
'core.pkg.css' => '0437a674',
12
+
'core.pkg.css' => '4ac857bf',
13
13
'core.pkg.js' => '6c085267',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '45951e9e',
···
32
32
'rsrc/css/aphront/notification.css' => '457861ec',
33
33
'rsrc/css/aphront/panel-view.css' => '8427b78d',
34
34
'rsrc/css/aphront/phabricator-nav-view.css' => 'faf6a6fc',
35
-
'rsrc/css/aphront/table-view.css' => 'a3aa6910',
35
+
'rsrc/css/aphront/table-view.css' => '8c9bbafe',
36
36
'rsrc/css/aphront/tokenizer.css' => '15d5ff71',
37
37
'rsrc/css/aphront/tooltip.css' => '173b9431',
38
38
'rsrc/css/aphront/typeahead-browse.css' => 'f2818435',
···
74
74
'rsrc/css/application/diffusion/diffusion-icons.css' => '0c15255e',
75
75
'rsrc/css/application/diffusion/diffusion-readme.css' => '419dd5b6',
76
76
'rsrc/css/application/diffusion/diffusion-repository.css' => 'ee6f20ec',
77
-
'rsrc/css/application/diffusion/diffusion-source.css' => '47db8a7c',
78
-
'rsrc/css/application/diffusion/diffusion.css' => 'ceacf994',
77
+
'rsrc/css/application/diffusion/diffusion-source.css' => '69ac9399',
78
+
'rsrc/css/application/diffusion/diffusion.css' => '9d5bb76d',
79
79
'rsrc/css/application/feed/feed.css' => 'ecd4ec57',
80
80
'rsrc/css/application/files/global-drag-and-drop.css' => 'b556a948',
81
81
'rsrc/css/application/flag/flag.css' => 'bba8f811',
···
110
110
'rsrc/css/application/releeph/releeph-preview-branch.css' => 'b7a6f4a5',
111
111
'rsrc/css/application/releeph/releeph-request-differential-create-dialog.css' => '8d8b92cd',
112
112
'rsrc/css/application/releeph/releeph-request-typeahead.css' => '667a48ae',
113
-
'rsrc/css/application/search/application-search-view.css' => '66ee5d46',
113
+
'rsrc/css/application/search/application-search-view.css' => '787f5b76',
114
114
'rsrc/css/application/search/search-results.css' => '505dd8cf',
115
115
'rsrc/css/application/slowvote/slowvote.css' => 'a94b7230',
116
116
'rsrc/css/application/tokens/tokens.css' => '3d0f239e',
···
543
543
'aphront-list-filter-view-css' => '5d6f0526',
544
544
'aphront-multi-column-view-css' => '84cc6640',
545
545
'aphront-panel-view-css' => '8427b78d',
546
-
'aphront-table-view-css' => 'a3aa6910',
546
+
'aphront-table-view-css' => '8c9bbafe',
547
547
'aphront-tokenizer-control-css' => '15d5ff71',
548
548
'aphront-tooltip-css' => '173b9431',
549
549
'aphront-typeahead-control-css' => 'a4a21016',
550
-
'application-search-view-css' => '66ee5d46',
550
+
'application-search-view-css' => '787f5b76',
551
551
'auth-css' => '0877ed6e',
552
552
'bulk-job-css' => 'df9c1d4a',
553
553
'conduit-api-css' => '7bc725c4',
···
570
570
'differential-revision-history-css' => '0e8eb855',
571
571
'differential-revision-list-css' => 'f3c47d33',
572
572
'differential-table-of-contents-css' => 'ae4b7a55',
573
-
'diffusion-css' => 'ceacf994',
573
+
'diffusion-css' => '9d5bb76d',
574
574
'diffusion-icons-css' => '0c15255e',
575
575
'diffusion-readme-css' => '419dd5b6',
576
576
'diffusion-repository-css' => 'ee6f20ec',
577
-
'diffusion-source-css' => '47db8a7c',
577
+
'diffusion-source-css' => '69ac9399',
578
578
'diviner-shared-css' => '896f1d43',
579
579
'font-fontawesome' => 'e838e088',
580
580
'font-lato' => 'c7ccd872',
+1
src/applications/diffusion/controller/DiffusionBranchTableController.php
+1
src/applications/diffusion/controller/DiffusionBranchTableController.php
+20
-6
src/applications/diffusion/controller/DiffusionBrowseController.php
+20
-6
src/applications/diffusion/controller/DiffusionBrowseController.php
···
371
371
->setHeader($browse_header)
372
372
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
373
373
->setTable($browse_table)
374
+
->addClass('diffusion-mobile-view')
374
375
->setPager($pager);
375
376
376
377
$path = $drequest->getPath();
···
595
596
),
596
597
$rows);
597
598
599
+
$corpus_table = phutil_tag_div('diffusion-source-wrap', $corpus_table);
600
+
598
601
if ($this->getRequest()->isAjax()) {
599
602
return $corpus_table;
600
603
}
···
654
657
->setHeader($header)
655
658
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
656
659
->appendChild($corpus)
660
+
->addClass('diffusion-mobile-view')
657
661
->setCollapsed(true);
658
662
659
663
$messages = array();
···
860
864
$view = id(new PHUIObjectBoxView())
861
865
->setHeaderText(pht('Owner Packages'))
862
866
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
867
+
->addClass('diffusion-mobile-view')
863
868
->setObjectList($ownership);
864
869
}
865
870
···
1341
1346
return id(new PHUIObjectBoxView())
1342
1347
->setHeader($header)
1343
1348
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
1349
+
->addClass('diffusion-mobile-view')
1344
1350
->addPropertyList($properties);
1345
1351
}
1346
1352
···
1361
1367
$box = id(new PHUIObjectBoxView())
1362
1368
->setHeader($header)
1363
1369
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
1370
+
->addClass('diffusion-mobile-view')
1364
1371
->appendChild($text);
1365
1372
1366
1373
return $box;
···
1693
1700
$header = id(new PHUIHeaderView())
1694
1701
->setHeader(pht('Recently Open Revisions'));
1695
1702
1696
-
$view = id(new DifferentialRevisionListView())
1697
-
->setHeader($header)
1698
-
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
1703
+
$list = id(new DifferentialRevisionListView())
1699
1704
->setRevisions($revisions)
1700
-
->setUser($viewer);
1705
+
->setUser($viewer)
1706
+
->setNoBox(true);
1701
1707
1702
-
$phids = $view->getRequiredHandlePHIDs();
1708
+
$phids = $list->getRequiredHandlePHIDs();
1703
1709
$handles = $this->loadViewerHandles($phids);
1704
-
$view->setHandles($handles);
1710
+
$list->setHandles($handles);
1711
+
1712
+
$view = id(new PHUIObjectBoxView())
1713
+
->setHeader($header)
1714
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
1715
+
->addClass('diffusion-mobile-view')
1716
+
->appendChild($list);
1705
1717
1706
1718
return $view;
1707
1719
}
···
1838
1850
$corpus = id(new PHUIObjectBoxView())
1839
1851
->setHeader($header)
1840
1852
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
1853
+
->addClass('diffusion-mobile-view')
1841
1854
->setCollapsed(true);
1842
1855
1843
1856
if ($messages) {
···
1922
1935
return id(new PHUIObjectBoxView())
1923
1936
->setHeader($header)
1924
1937
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
1938
+
->addClass('diffusion-mobile-view')
1925
1939
->setTable($history_table);
1926
1940
}
1927
1941
+2
src/applications/diffusion/controller/DiffusionCompareController.php
+2
src/applications/diffusion/controller/DiffusionCompareController.php
···
15
15
$viewer = $this->getViewer();
16
16
$drequest = $this->getDiffusionRequest();
17
17
$repository = $drequest->getRepository();
18
+
require_celerity_resource('diffusion-css');
18
19
19
20
if (!$repository->supportsBranchComparison()) {
20
21
return $this->newDialog()
···
315
316
->setHeader($header)
316
317
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
317
318
->setTable($history_table)
319
+
->addClass('diffusion-mobile-view')
318
320
->setPager($pager);
319
321
320
322
}
+1
src/applications/diffusion/controller/DiffusionGraphController.php
+1
src/applications/diffusion/controller/DiffusionGraphController.php
+3
-1
src/applications/diffusion/controller/DiffusionRepositoryController.php
+3
-1
src/applications/diffusion/controller/DiffusionRepositoryController.php
···
420
420
$history_table->setIsHead(true);
421
421
422
422
$panel = id(new PHUIObjectBoxView())
423
-
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY);
423
+
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
424
+
->addClass('diffusion-mobile-view');
424
425
$header = id(new PHUIHeaderView())
425
426
->setHeader(pht('Recent Commits'));
426
427
$panel->setHeader($header);
···
583
584
->setHeaderText($header)
584
585
->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
585
586
->setTable($browse_table)
587
+
->addClass('diffusion-mobile-view')
586
588
->setPager($pager);
587
589
}
588
590
+1
-1
src/applications/diffusion/view/DiffusionBrowseTableView.php
+1
-1
src/applications/diffusion/view/DiffusionBrowseTableView.php
+1
src/applications/diffusion/view/DiffusionHistoryListView.php
+1
src/applications/diffusion/view/DiffusionHistoryListView.php
+1
src/applications/diffusion/view/DiffusionReadmeView.php
+1
src/applications/diffusion/view/DiffusionReadmeView.php
+1
-6
webroot/rsrc/css/aphront/table-view.css
+1
-6
webroot/rsrc/css/aphront/table-view.css
···
4
4
5
5
.aphront-table-wrap {
6
6
overflow-x: auto;
7
+
-webkit-overflow-scrolling: touch;
7
8
}
8
9
9
10
.aphront-table-view {
···
128
129
padding: 8px 10px;
129
130
}
130
131
131
-
.device-tablet .aphront-table-view td,
132
-
.device-phone .aphront-table-view td {
133
-
padding: 6px;
134
-
}
135
-
136
132
.device-tablet .aphront-table-view th,
137
133
.device-phone .aphront-table-view th {
138
-
padding: 6px;
139
134
overflow: hidden;
140
135
}
141
136
+11
webroot/rsrc/css/application/diffusion/diffusion-source.css
+11
webroot/rsrc/css/application/diffusion/diffusion-source.css
···
5
5
.diffusion-source {
6
6
width: 100%;
7
7
background: {$page.content};
8
+
overflow: hidden;
9
+
}
10
+
11
+
.device-phone .diffusion-source-wrap {
12
+
overflow: scroll;
13
+
-webkit-overflow-scrolling: touch;
8
14
}
9
15
10
16
.diffusion-source tr.phabricator-source-highlight th,
···
25
31
padding: 3px 12px;
26
32
width: 100%;
27
33
word-break: break-all;
34
+
}
35
+
36
+
.device .diffusion-source td {
37
+
word-break: normal;
38
+
white-space: nowrap;
28
39
}
29
40
30
41
.diffusion-browse-type-form {
+6
-13
webroot/rsrc/css/application/diffusion/diffusion.css
+6
-13
webroot/rsrc/css/application/diffusion/diffusion.css
···
207
207
border-color: {$thinblueborder};
208
208
}
209
209
210
-
.device-phone.diffusion-history-view .phui-two-column-view
211
-
.phui-two-column-footer .phui-header-view {
212
-
text-align: center;
213
-
}
214
-
215
-
.device-phone.diffusion-history-view .phui-two-column-content {
216
-
padding: 0;
217
-
margin: 0 -4px;
218
-
}
219
-
220
210
.device-phone.diffusion-history-view .phui-oi-attribute-spacer {
221
211
display: none;
222
212
}
···
245
235
margin: 0;
246
236
}
247
237
248
-
.device-phone.diffusion-history-view .diffusion-history-list .button.has-icon
249
-
.phui-icon-view {
250
-
display: none;
238
+
.device-phone .phui-two-column-view .phui-two-column-content
239
+
.phui-object-box.diffusion-mobile-view {
240
+
margin: 0 -12px 20px;
241
+
border-left: none;
242
+
border-right: none;
243
+
border-color: {$thinblueborder};
251
244
}
+1
-1
webroot/rsrc/css/application/search/application-search-view.css
+1
-1
webroot/rsrc/css/application/search/application-search-view.css