recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Stop populating or updating working copies in observed Mercurial repositories

Summary:
Ref T12961. Fixes T4416. Currently, for observed Mercurial repositories, we build a working copy with `pull -u` (for "update").

This should be unnecessary, and we don't do it for hosted Mercurial repositories. We also stopped doing it years ago for Git repositories. We also don't clone Mercurial repositories with a working copy.

It's possible something has slipped through the cracks here so I'll hold this until after the release cut, but I believe there are no actual technical blockers here.

Test Plan:
- Observed a public Mercurial repository on Bitbucket.
- Let it import.
- Browsed commits, branches, file content, etc., without any apparent issues.

Reviewers: chad

Reviewed By: chad

Subscribers: cspeckmim

Maniphest Tasks: T12961, T4416

Differential Revision: https://secure.phabricator.com/D18390

epriestley 2c150076 794e185b

+1 -1
+1 -1
src/applications/repository/engine/PhabricatorRepositoryPullEngine.php
··· 529 529 530 530 // This is a local command, but needs credentials. 531 531 $remote = $repository->getRemoteURIEnvelope(); 532 - $future = $repository->getRemoteCommandFuture('pull -u -- %P', $remote); 532 + $future = $repository->getRemoteCommandFuture('pull -- %P', $remote); 533 533 $future->setCWD($path); 534 534 535 535 try {