@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix app icons in homepage settings
Summary: These were blank, from last week's shenanigans.
Test Plan: View homepage settings, see icons.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D16447
authored by
Chad Little
and committed by
chad
2c9a93ed
605210bc
+2
-10
+2
-10
src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php
+2
-10
src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php
···
152
152
153
153
$icon = $application->getIcon();
154
154
if (!$icon) {
155
-
$icon = 'application';
155
+
$icon = 'fa-globe';
156
156
}
157
157
158
-
$icon_view = javelin_tag(
159
-
'span',
160
-
array(
161
-
'class' => 'phui-icon-view phui-font-fa '.$icon,
162
-
'aural' => false,
163
-
),
164
-
'');
165
-
166
158
$item = id(new PHUIObjectItemView())
167
159
->setHeader($application->getName())
168
-
->setImageIcon($icon_view)
160
+
->setImageIcon($icon)
169
161
->addAttribute($application->getShortDescription())
170
162
->setGrippable(true);
171
163