@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Various linter fixes
Summary: Self explanatory.
Test Plan: `arc lint`
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D13863
+78
-46
+8
-7
src/aphront/configuration/AphrontApplicationConfiguration.php
+8
-7
src/aphront/configuration/AphrontApplicationConfiguration.php
···
246
246
if ($response instanceof AphrontWebpageResponse) {
247
247
echo phutil_tag(
248
248
'div',
249
-
array('style' =>
250
-
'background: #eeddff;'.
251
-
'white-space: pre-wrap;'.
252
-
'z-index: 200000;'.
253
-
'position: relative;'.
254
-
'padding: 8px;'.
255
-
'font-family: monospace',
249
+
array(
250
+
'style' =>
251
+
'background: #eeddff;'.
252
+
'white-space: pre-wrap;'.
253
+
'z-index: 200000;'.
254
+
'position: relative;'.
255
+
'padding: 8px;'.
256
+
'font-family: monospace',
256
257
),
257
258
$unexpected_output);
258
259
}
+8
-6
src/applications/conpherence/__tests__/ConpherenceTestCase.php
+8
-6
src/applications/conpherence/__tests__/ConpherenceTestCase.php
···
7
7
ConpherenceThread $conpherence,
8
8
array $participant_phids) {
9
9
10
-
$xactions = array(id(new ConpherenceTransaction())
11
-
->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
12
-
->setNewValue(array('+' => $participant_phids)),
10
+
$xactions = array(
11
+
id(new ConpherenceTransaction())
12
+
->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
13
+
->setNewValue(array('+' => $participant_phids)),
13
14
);
14
15
$editor = id(new ConpherenceEditor())
15
16
->setActor($actor)
···
23
24
ConpherenceThread $conpherence,
24
25
array $participant_phids) {
25
26
26
-
$xactions = array(id(new ConpherenceTransaction())
27
-
->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
28
-
->setNewValue(array('-' => $participant_phids)),
27
+
$xactions = array(
28
+
id(new ConpherenceTransaction())
29
+
->setTransactionType(ConpherenceTransaction::TYPE_PARTICIPANTS)
30
+
->setNewValue(array('-' => $participant_phids)),
29
31
);
30
32
$editor = id(new ConpherenceEditor())
31
33
->setActor($actor)
+4
-3
src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
+4
-3
src/applications/differential/conduit/DifferentialCreateDiffConduitAPIMethod.php
···
143
143
'unitStatus' => $unit_status,
144
144
);
145
145
146
-
$xactions = array(id(new DifferentialTransaction())
147
-
->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
148
-
->setNewValue($diff_data_dict),
146
+
$xactions = array(
147
+
id(new DifferentialTransaction())
148
+
->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
149
+
->setNewValue($diff_data_dict),
149
150
);
150
151
151
152
id(new DifferentialDiffEditor())
+4
-3
src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php
+4
-3
src/applications/differential/conduit/DifferentialCreateRawDiffConduitAPIMethod.php
···
51
51
'unitStatus' => DifferentialUnitStatus::UNIT_SKIP,
52
52
);
53
53
54
-
$xactions = array(id(new DifferentialTransaction())
55
-
->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
56
-
->setNewValue($diff_data_dict),
54
+
$xactions = array(
55
+
id(new DifferentialTransaction())
56
+
->setTransactionType(DifferentialDiffTransaction::TYPE_DIFF_CREATE)
57
+
->setNewValue($diff_data_dict),
57
58
);
58
59
59
60
if ($request->getValue('viewPolicy')) {
+3
-3
src/applications/differential/parser/DifferentialHunkParser.php
+3
-3
src/applications/differential/parser/DifferentialHunkParser.php
···
603
603
$start = $start - $add_context;
604
604
$end = $end + $add_context;
605
605
$hunk_content = array();
606
-
$hunk_pos = array( '-' => 0, '+' => 0 );
607
-
$hunk_offset = array( '-' => null, '+' => null );
608
-
$hunk_last = array( '-' => null, '+' => null );
606
+
$hunk_pos = array('-' => 0, '+' => 0);
607
+
$hunk_offset = array('-' => null, '+' => null);
608
+
$hunk_last = array('-' => null, '+' => null);
609
609
foreach (explode("\n", $hunk->getChanges()) as $line) {
610
610
$in_common = strncmp($line, ' ', 1) === 0;
611
611
$in_old = strncmp($line, '-', 1) === 0 || $in_common;
+1
-1
src/applications/home/controller/PhabricatorHomeMainController.php
+1
-1
src/applications/home/controller/PhabricatorHomeMainController.php
+4
-3
src/applications/passphrase/controller/PassphraseCredentialRevealController.php
+4
-3
src/applications/passphrase/controller/PassphraseCredentialRevealController.php
···
67
67
->addCancelButton($view_uri, pht('Done'));
68
68
69
69
$type_secret = PassphraseCredentialTransaction::TYPE_LOOKEDATSECRET;
70
-
$xactions = array(id(new PassphraseCredentialTransaction())
71
-
->setTransactionType($type_secret)
72
-
->setNewValue(true),
70
+
$xactions = array(
71
+
id(new PassphraseCredentialTransaction())
72
+
->setTransactionType($type_secret)
73
+
->setNewValue(true),
73
74
);
74
75
75
76
$editor = id(new PassphraseCredentialTransactionEditor())
+4
-3
src/applications/project/controller/PhabricatorProjectColumnHideController.php
+4
-3
src/applications/project/controller/PhabricatorProjectColumnHideController.php
···
60
60
}
61
61
62
62
$type_status = PhabricatorProjectColumnTransaction::TYPE_STATUS;
63
-
$xactions = array(id(new PhabricatorProjectColumnTransaction())
64
-
->setTransactionType($type_status)
65
-
->setNewValue($new_status),
63
+
$xactions = array(
64
+
id(new PhabricatorProjectColumnTransaction())
65
+
->setTransactionType($type_status)
66
+
->setNewValue($new_status),
66
67
);
67
68
68
69
$editor = id(new PhabricatorProjectColumnTransactionEditor())
+1
-1
src/applications/search/engine/PhabricatorElasticSearchEngine.php
+1
-1
src/applications/search/engine/PhabricatorElasticSearchEngine.php
···
325
325
foreach ($types as $type) {
326
326
// Use the custom trigram analyzer for the corpus of text
327
327
$data['mappings'][$type]['properties']['field']['properties']['corpus'] =
328
-
array( 'type' => 'string', 'analyzer' => 'custom_trigrams' );
328
+
array('type' => 'string', 'analyzer' => 'custom_trigrams');
329
329
330
330
// Ensure we have dateCreated since the default query requires it
331
331
$data['mappings'][$type]['properties']['dateCreated']['type'] = 'string';
+2
-1
src/applications/uiexample/examples/PHUIButtonExample.php
+2
-1
src/applications/uiexample/examples/PHUIButtonExample.php
+1
-3
src/infrastructure/sms/worker/PhabricatorSMSWorker.php
+1
-3
src/infrastructure/sms/worker/PhabricatorSMSWorker.php
+15
-4
src/infrastructure/storage/lisk/__tests__/LiskChunkTestCase.php
+15
-4
src/infrastructure/storage/lisk/__tests__/LiskChunkTestCase.php
···
4
4
5
5
public function testSQLChunking() {
6
6
$fragments = array(
7
-
'a', 'a',
8
-
'b', 'b',
7
+
'a',
8
+
'a',
9
+
'b',
10
+
'b',
9
11
'ccc',
10
12
'dd',
11
13
'e',
···
23
25
24
26
25
27
$fragments = array(
26
-
'a', 'a', 'a', 'XX', 'a', 'a', 'a', 'a',
28
+
'a',
29
+
'a',
30
+
'a',
31
+
'XX',
32
+
'a',
33
+
'a',
34
+
'a',
35
+
'a',
27
36
);
28
37
29
38
$this->assertEqual(
···
38
47
$fragments = array(
39
48
'xxxxxxxxxx',
40
49
'yyyyyyyyyy',
41
-
'a', 'b', 'c',
50
+
'a',
51
+
'b',
52
+
'c',
42
53
'zzzzzzzzzz',
43
54
);
44
55
+17
-3
src/infrastructure/util/__tests__/PhabricatorHashTestCase.php
+17
-3
src/infrastructure/util/__tests__/PhabricatorHashTestCase.php
···
19
19
20
20
// Test that the encoding produces 6 bits of entropy per byte.
21
21
$entropy = array(
22
-
'dog', 'cat', 'rat', 'bat', 'dig', 'fig', 'cot',
23
-
'cut', 'fog', 'rig', 'rug', 'dug', 'mat', 'pat',
24
-
'eat', 'tar', 'pot',
22
+
'dog',
23
+
'cat',
24
+
'rat',
25
+
'bat',
26
+
'dig',
27
+
'fig',
28
+
'cot',
29
+
'cut',
30
+
'fog',
31
+
'rig',
32
+
'rug',
33
+
'dug',
34
+
'mat',
35
+
'pat',
36
+
'eat',
37
+
'tar',
38
+
'pot',
25
39
);
26
40
27
41
$seen = array();
+5
-4
src/view/AphrontDialogView.php
+5
-4
src/view/AphrontDialogView.php
···
290
290
}
291
291
292
292
if (!$this->renderAsForm) {
293
-
$buttons = array(phabricator_form(
294
-
$this->user,
295
-
$form_attributes,
296
-
array_merge($hidden_inputs, $buttons)),
293
+
$buttons = array(
294
+
phabricator_form(
295
+
$this->user,
296
+
$form_attributes,
297
+
array_merge($hidden_inputs, $buttons)),
297
298
);
298
299
}
299
300