@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Tidy up ManiphestTask destruction
Summary: Now that `ManiphestTask` implements `PhabricatorApplicationTransactionInterface`, the transaction removal happens automatically.
Test Plan: Used `./bin/remove destroy` to delete a `ManiphestTask` and saw related transactions removed as well.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D13110
+1
-11
+1
-11
src/applications/maniphest/storage/ManiphestTask.php
+1
-11
src/applications/maniphest/storage/ManiphestTask.php
···
352
352
PhabricatorDestructionEngine $engine) {
353
353
354
354
$this->openTransaction();
355
-
356
-
// TODO: Once this implements PhabricatorTransactionInterface, this
357
-
// will be handled automatically and can be removed.
358
-
$xactions = id(new ManiphestTransaction())->loadAllWhere(
359
-
'objectPHID = %s',
360
-
$this->getPHID());
361
-
foreach ($xactions as $xaction) {
362
-
$engine->destroyObject($xaction);
363
-
}
364
-
365
-
$this->delete();
355
+
$this->delete();
366
356
$this->saveTransaction();
367
357
}
368
358