@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix a bad link target in Diffusion content search results
Summary: See <https://discourse.phabricator-community.org/t/broken-links-in-diffusion-pattern-search-results-page/757>. This links to the display path, which is incorrect.
Test Plan:
- In any repository, browsed into a directory.
- Used pattern search to search for something that hits results.
- Clicked the title (filename/path) of a result table.
- Before patch: URL omits path context, 404 or wrong result.
- After patch: taken to proper page.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D18779
+5
-4
+5
-4
src/applications/diffusion/view/DiffusionPatternSearchView.php
+5
-4
src/applications/diffusion/view/DiffusionPatternSearchView.php
···
96
96
97
97
$path_title = Filesystem::readablePath($this->path, $drequest->getPath());
98
98
99
-
$href = $drequest->generateURI(array(
100
-
'action' => 'browse',
101
-
'path' => $path_title,
102
-
));
99
+
$href = $drequest->generateURI(
100
+
array(
101
+
'action' => 'browse',
102
+
'path' => $this->path,
103
+
));
103
104
104
105
$title = phutil_tag('a', array('href' => $href), $path_title);
105
106