recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix MenuItem names not getting attached

Summary:
- Attach objects when showing configuration screen
- Fix "Forms" to make more sense
- Alter EditEngine title to load correct name by loading object

Fixes T12116

Test Plan: Load up Apps/Projects/Forms on a configure menu, see proper names

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12116

Differential Revision: https://secure.phabricator.com/D17217

Chad Little 2d4eb460 9d3f09ab

+8 -1
+1
src/applications/search/editor/PhabricatorProfileMenuEditEngine.php
··· 109 109 } 110 110 111 111 protected function getObjectEditTitleText($object) { 112 + $object->willBuildNavigationItems(array($object)); 112 113 return pht('Edit Menu Item: %s', $object->getDisplayName()); 113 114 } 114 115
+6
src/applications/search/engine/PhabricatorProfileMenuEngine.php
··· 551 551 $viewer = $this->getViewer(); 552 552 $object = $this->getProfileObject(); 553 553 554 + $filtered_groups = mgroup($items, 'getMenuItemKey'); 555 + foreach ($filtered_groups as $group) { 556 + $first_item = head($group); 557 + $first_item->willBuildNavigationItems($group); 558 + } 559 + 554 560 PhabricatorPolicyFilter::requireCapability( 555 561 $viewer, 556 562 $object,
+1 -1
src/applications/search/menuitem/PhabricatorEditEngineProfileMenuItem.php
··· 12 12 } 13 13 14 14 public function getMenuItemTypeName() { 15 - return pht('Forms'); 15 + return pht('Form'); 16 16 } 17 17 18 18 public function canAddToObject($object) {