@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add some more UI reminder text about draft revisions
Summary: See PHI433. This beefs up reminder texts for drafts a little bit since some users in the wild aren't always seeing/remembering the existing, fairly subtle hints.
Test Plan: Created a reivsion with `--draft`, viewed it, saw richer reminders.
Differential Revision: https://secure.phabricator.com/D19204
+33
-5
+3
-3
src/applications/differential/constants/DifferentialRevisionStatus.php
+3
-3
src/applications/differential/constants/DifferentialRevisionStatus.php
···
172
172
'name' => pht('Draft'),
173
173
// For legacy clients, treat this as though it is "Needs Review".
174
174
'legacy' => 0,
175
-
'icon' => 'fa-file-text-o',
175
+
'icon' => 'fa-spinner',
176
176
'closed' => false,
177
-
'color.icon' => 'grey',
178
-
'color.tag' => 'grey',
177
+
'color.icon' => 'pink',
178
+
'color.tag' => 'pink',
179
179
'color.ansi' => null,
180
180
),
181
181
);
+22
-2
src/applications/differential/customfield/DifferentialDraftField.php
+22
-2
src/applications/differential/customfield/DifferentialDraftField.php
···
37
37
}
38
38
39
39
// If the author has held this revision as a draft explicitly, don't
40
-
// show any misleading messages about it autosubmitting later.
40
+
// show any misleading messages about it autosubmitting later. We do show
41
+
// reminder text.
41
42
if ($revision->getHoldAsDraft()) {
42
-
return array();
43
+
return array(
44
+
pht(
45
+
'This is a draft revision that has not yet been submitted for '.
46
+
'review.'),
47
+
);
43
48
}
44
49
45
50
$warnings = array();
···
91
96
}
92
97
93
98
return $warnings;
99
+
}
100
+
101
+
public function getWarningsForDetailView() {
102
+
$revision = $this->getObject();
103
+
104
+
if (!$revision->isDraft()) {
105
+
return array();
106
+
}
107
+
108
+
return array(
109
+
pht(
110
+
'This revision is currently a draft. You can leave comments, but '.
111
+
'no one will be notified until the revision is submitted for '.
112
+
'review.'),
113
+
);
94
114
}
95
115
96
116
}
+8
src/applications/differential/editor/DifferentialRevisionEditEngine.php
+8
src/applications/differential/editor/DifferentialRevisionEditEngine.php
···
71
71
return pht('Revision');
72
72
}
73
73
74
+
protected function getCommentViewButtonText($object) {
75
+
if ($object->isDraft()) {
76
+
return pht('Submit Quietly');
77
+
}
78
+
79
+
return parent::getCommentViewButtonText();
80
+
}
81
+
74
82
protected function getObjectViewURI($object) {
75
83
return $object->getURI();
76
84
}