@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update continue/break for php 7.3
Summary:
Fixes https://discourse.phabricator-community.org/t/error-on-project-creation-or-edition-with-php7-3/2236
I didn't actually repro this because I don't have php 7.3 installed. I'm also not sure if the `break; break` was intentional or not, since I'm not sure you could ever reach two consecutive break statements.
Test Plan: Created some projects. Didn't actually try to hit the code that fires if you're making a project both a subproject and a milestone.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D19925
+3
-4
+3
-4
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
+3
-4
src/applications/project/editor/PhabricatorProjectTransactionEditor.php
···
55
55
case PhabricatorProjectParentTransaction::TRANSACTIONTYPE:
56
56
case PhabricatorProjectMilestoneTransaction::TRANSACTIONTYPE:
57
57
if ($xaction->getNewValue() === null) {
58
-
continue;
58
+
continue 2;
59
59
}
60
60
61
61
if (!$parent_xaction) {
62
62
$parent_xaction = $xaction;
63
-
continue;
63
+
continue 2;
64
64
}
65
65
66
66
$errors[] = new PhabricatorApplicationTransactionValidationError(
···
71
71
'project or milestone project. A project can not be both a '.
72
72
'subproject and a milestone.'),
73
73
$xaction);
74
-
break;
75
-
break;
74
+
break 2;
76
75
}
77
76
}
78
77