+1 -1

src/applications/differential/controller/DifferentialRevisionViewController.php

reviewed

··· 278 278 $changeset_view->setVsMap($vs_map); 279 279 $changeset_view->setWhitespace($whitespace); 280 280 if ($repository) { 281 281 - $changeset_view->setRepository($repository, $target); 281 281 + $changeset_view->setRepository($repository); 282 282 } 283 283 $changeset_view->setSymbolIndexes($symbol_indexes); 284 284

+1 -1

src/applications/herald/config/HeraldActionConfig.php

reviewed

··· 97 97 self::ACTION_NOTHING, 98 98 )); 99 99 default: 100 100 - throw new Exception("Unknown content type '{$type}'."); 100 100 + throw new Exception("Unknown content type '{$content_type}'."); 101 101 } 102 102 } 103 103

+1 -1

src/applications/maniphest/controller/ManiphestTaskEditController.php

reviewed

··· 327 327 $phids = array_unique($phids); 328 328 329 329 $handles = id(new PhabricatorObjectHandleData($phids)) 330 330 - ->loadHandles($phids); 330 330 + ->loadHandles(); 331 331 332 332 $tvalues = mpull($handles, 'getFullName', 'getPHID'); 333 333

+1 -1

src/applications/oauthserver/controller/PhabricatorOAuthServerTestController.php

reviewed

··· 29 29 public function processRequest() { 30 30 $request = $this->getRequest(); 31 31 $current_user = $request->getUser(); 32 32 - $server = new PhabricatorOAuthServer($current_user); 32 32 + $server = new PhabricatorOAuthServer(); 33 33 $panels = array(); 34 34 $results = array(); 35 35

+5 -5

src/applications/phame/controller/post/PhamePostViewController.php

reviewed

··· 94 94 } else if ($this->getBloggerName() && $this->getPhameTitle()) { 95 95 $phame_title = $this->getPhameTitle(); 96 96 $phame_title = PhabricatorSlug::normalize($phame_title); 97 97 - if ($phame_title != $this->getPhameTitle()) { 98 98 - $uri = $post->getViewURI($this->getBloggerName()); 99 99 - return id(new AphrontRedirectResponse())->setURI($uri); 100 100 - } 101 97 $blogger = id(new PhabricatorUser())->loadOneWhere( 102 98 'username = %s', 103 99 $this->getBloggerName()); ··· 107 103 $post = id(new PhamePost())->loadOneWhere( 108 104 'bloggerPHID = %s AND phameTitle = %s', 109 105 $blogger->getPHID(), 110 110 - $this->getPhameTitle()); 106 106 + $phame_title); 107 107 + if ($post && $phame_title != $this->getPhameTitle()) { 108 108 + $uri = $post->getViewURI($this->getBloggerName()); 109 109 + return id(new AphrontRedirectResponse())->setURI($uri); 110 110 + } 111 111 } 112 112 113 113 if (!$post) {

+3 -2

src/applications/project/controller/PhabricatorProjectProfileController.php

reviewed

··· 345 345 } 346 346 347 347 private function renderSubprojectTable( 348 348 - PhabricatorObjectHandleData $handles, 349 349 - $subprojects_phids) { 348 348 + array $handles, 349 349 + array $subprojects_phids) { 350 350 + assert_instances_of($handles, 'PhabricatorObjectHandle'); 350 351 351 352 $rows = array(); 352 353 foreach ($subprojects_phids as $subproject_phid) {

+4 -2

src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php

reviewed

··· 67 67 array( 68 68 'name' => 'not', 69 69 'param' => 'repository', 70 70 + 'default' => array(), 70 71 'repeat' => true, 71 72 'help' => 'Do not pull __repository__.', 72 73 ), 73 74 array( 74 75 'name' => 'repositories', 76 76 + 'default' => array(), 75 77 'wildcard' => true, 76 78 'help' => 'Pull specific __repositories__ instead of all.', 77 79 ), 78 80 )); 79 81 80 82 $no_discovery = $args->getArg('no-discovery'); 81 81 - $repo_names = $args->getArg('repositories', array()); 82 82 - $exclude_names = $args->getArg('not', array()); 83 83 + $repo_names = $args->getArg('repositories'); 84 84 + $exclude_names = $args->getArg('not'); 83 85 84 86 // Each repository has an individual pull frequency; after we pull it, 85 87 // wait that long to pull it again. When we start up, try to pull everything

+1 -1

src/applications/search/engine/PhabricatorJumpNavHandler.php

reviewed

··· 94 94 private static function findCloselyNamedProject($name) { 95 95 $project = id(new PhabricatorProject())->loadOneWhere( 96 96 'name = %s', 97 97 - name); 97 97 + $name); 98 98 if ($project) { 99 99 return $project; 100 100 } else { // no exact match, try a fuzzy match

+3 -3

src/infrastructure/daemon/workers/PhabricatorTaskmasterDaemon.php

reviewed

··· 36 36 $rows = $conn_w->getAffectedRows(); 37 37 38 38 if (!$rows) { 39 39 - $rows = queryfx( 39 39 + queryfx( 40 40 $conn_w, 41 41 'UPDATE %T SET leaseOwner = %s, leaseExpires = UNIX_TIMESTAMP() + 15 42 42 WHERE leaseExpires < UNIX_TIMESTAMP() LIMIT 1', 43 43 - $task_table->getTableName(), 44 44 - $lease_ownership_name); 43 43 + $task_table->getTableName(), 44 44 + $lease_ownership_name); 45 45 $rows = $conn_w->getAffectedRows(); 46 46 } 47 47