@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Simplify Differential "Summary" field
Summary: Ref T11114. Keep UI stuff and mail stuff, toss editing.
Test Plan: Viewed and edited revision summaries.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17085
-84
-84
src/applications/differential/customfield/DifferentialSummaryField.php
-84
src/applications/differential/customfield/DifferentialSummaryField.php
···
7
7
return 'differential:summary';
8
8
}
9
9
10
-
public function getFieldKeyForConduit() {
11
-
return 'summary';
12
-
}
13
-
14
10
public function getFieldName() {
15
11
return pht('Summary');
16
12
}
···
27
23
return $revision->getSummary();
28
24
}
29
25
30
-
protected function writeValueToRevision(
31
-
DifferentialRevision $revision,
32
-
$value) {
33
-
$revision->setSummary($value);
34
-
}
35
-
36
-
public function readValueFromRequest(AphrontRequest $request) {
37
-
$this->setValue($request->getStr($this->getFieldKey()));
38
-
}
39
-
40
-
public function renderEditControl(array $handles) {
41
-
return id(new PhabricatorRemarkupControl())
42
-
->setUser($this->getViewer())
43
-
->setName($this->getFieldKey())
44
-
->setValue($this->getValue())
45
-
->setError($this->getFieldError())
46
-
->setLabel($this->getFieldName());
47
-
}
48
-
49
-
public function getApplicationTransactionTitle(
50
-
PhabricatorApplicationTransaction $xaction) {
51
-
$author_phid = $xaction->getAuthorPHID();
52
-
$old = $xaction->getOldValue();
53
-
$new = $xaction->getNewValue();
54
-
55
-
return pht(
56
-
'%s updated the summary for this revision.',
57
-
$xaction->renderHandleLink($author_phid));
58
-
}
59
-
60
-
public function getApplicationTransactionTitleForFeed(
61
-
PhabricatorApplicationTransaction $xaction) {
62
-
63
-
$object_phid = $xaction->getObjectPHID();
64
-
$author_phid = $xaction->getAuthorPHID();
65
-
$old = $xaction->getOldValue();
66
-
$new = $xaction->getNewValue();
67
-
68
-
return pht(
69
-
'%s updated the summary for %s.',
70
-
$xaction->renderHandleLink($author_phid),
71
-
$xaction->renderHandleLink($object_phid));
72
-
}
73
-
74
-
public function getApplicationTransactionHasChangeDetails(
75
-
PhabricatorApplicationTransaction $xaction) {
76
-
return true;
77
-
}
78
-
79
-
public function getApplicationTransactionChangeDetails(
80
-
PhabricatorApplicationTransaction $xaction,
81
-
PhabricatorUser $viewer) {
82
-
return $xaction->renderTextCorpusChangeDetails(
83
-
$viewer,
84
-
$xaction->getOldValue(),
85
-
$xaction->getNewValue());
86
-
}
87
-
88
-
public function shouldHideInApplicationTransactions(
89
-
PhabricatorApplicationTransaction $xaction) {
90
-
return ($xaction->getOldValue() === null);
91
-
}
92
-
93
26
public function shouldAppearInGlobalSearch() {
94
27
return true;
95
28
}
···
123
56
}
124
57
125
58
return new PHUIRemarkupView($this->getViewer(), $this->getValue());
126
-
}
127
-
128
-
public function getApplicationTransactionRemarkupBlocks(
129
-
PhabricatorApplicationTransaction $xaction) {
130
-
return array($xaction->getNewValue());
131
-
}
132
-
133
-
public function shouldAppearInCommitMessage() {
134
-
return true;
135
-
}
136
-
137
-
public function shouldAppearInCommitMessageTemplate() {
138
-
return true;
139
-
}
140
-
141
-
public function shouldOverwriteWhenCommitMessageIsEdited() {
142
-
return true;
143
59
}
144
60
145
61
public function shouldAppearInTransactionMail() {