@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Move Conpherence to "Zxxx" only, not "Exxx"
Summary: Fixes T7439. Also two callsites I missed earlier.
Test Plan: Tried to search for strings like `'E` and `"E`.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T7439
Differential Revision: https://secure.phabricator.com/D12616
+4
-6
+2
-2
src/applications/conpherence/editor/ConpherenceEditor.php
+2
-2
src/applications/conpherence/editor/ConpherenceEditor.php
···
497
497
$phid = $object->getPHID();
498
498
499
499
return id(new PhabricatorMetaMTAMail())
500
-
->setSubject("E{$id}: {$title}")
501
-
->addHeader('Thread-Topic', "E{$id}: {$phid}");
500
+
->setSubject("Z{$id}: {$title}")
501
+
->addHeader('Thread-Topic', "Z{$id}: {$phid}");
502
502
}
503
503
504
504
protected function getMailTo(PhabricatorLiskDAO $object) {
+2
-4
src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php
+2
-4
src/applications/conpherence/mail/ConpherenceThreadMailReceiver.php
···
9
9
}
10
10
11
11
protected function getObjectPattern() {
12
-
// TODO: Only recognize "Z" once we get closer to shipping Calendar.
13
-
return '[EZ][1-9]\d*';
12
+
return 'Z[1-9]\d*';
14
13
}
15
14
16
15
protected function loadObject($pattern, PhabricatorUser $viewer) {
17
-
// TODO: Only recognize "Z" once we get closer to shipping Calendar.
18
-
$id = (int)trim($pattern, 'EZ');
16
+
$id = (int)trim($pattern, 'Z');
19
17
20
18
return id(new ConpherenceThreadQuery())
21
19
->setViewer($viewer)