@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Don't revert Conpherence page titles when updating notifications

Summary: Fixes T7709. `JX.Title` deals with adding `(1)`, etc., counts, so send updates through it.

Test Plan: Clicked between some threads in Conpherence, no title flickering.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7709

Differential Revision: https://secure.phabricator.com/D12260

+30 -22
+21 -20
resources/celerity/map.php
··· 8 8 return array( 9 9 'names' => array( 10 10 'core.pkg.css' => '559c85eb', 11 - 'core.pkg.js' => '6be6b2fa', 11 + 'core.pkg.js' => '6a4f677f', 12 12 'darkconsole.pkg.js' => '8ab24e01', 13 13 'differential.pkg.css' => '3500921f', 14 14 'differential.pkg.js' => 'c0506961', ··· 355 355 'rsrc/js/application/config/behavior-reorder-fields.js' => '14a827de', 356 356 'rsrc/js/application/conpherence/ConpherenceThreadManager.js' => 'bb928342', 357 357 'rsrc/js/application/conpherence/behavior-durable-column.js' => 'a0216452', 358 - 'rsrc/js/application/conpherence/behavior-menu.js' => 'cda6de80', 358 + 'rsrc/js/application/conpherence/behavior-menu.js' => 'db6c0ba7', 359 359 'rsrc/js/application/conpherence/behavior-pontificate.js' => '21ba5861', 360 360 'rsrc/js/application/conpherence/behavior-quicksand-blacklist.js' => '7927a7d3', 361 361 'rsrc/js/application/conpherence/behavior-widget-pane.js' => '1ec93bcf', ··· 449 449 'rsrc/js/core/Prefab.js' => '72da38cc', 450 450 'rsrc/js/core/ShapedRequest.js' => '7cbe244b', 451 451 'rsrc/js/core/TextAreaUtils.js' => '5c93c52c', 452 - 'rsrc/js/core/Title.js' => '5c1c758c', 452 + 'rsrc/js/core/Title.js' => 'df5e11d2', 453 453 'rsrc/js/core/ToolTip.js' => '1d298e3a', 454 454 'rsrc/js/core/behavior-active-nav.js' => 'e379b58e', 455 455 'rsrc/js/core/behavior-audio-source.js' => '59b251eb', ··· 557 557 'javelin-behavior-boards-dropdown' => '0ec56e1d', 558 558 'javelin-behavior-choose-control' => '6153c708', 559 559 'javelin-behavior-config-reorder-fields' => '14a827de', 560 - 'javelin-behavior-conpherence-menu' => 'cda6de80', 560 + 'javelin-behavior-conpherence-menu' => 'db6c0ba7', 561 561 'javelin-behavior-conpherence-pontificate' => '21ba5861', 562 562 'javelin-behavior-conpherence-widget-pane' => '1ec93bcf', 563 563 'javelin-behavior-countdown-timer' => 'e4cc26b3', ··· 746 746 'phabricator-source-code-view-css' => '2ceee894', 747 747 'phabricator-standard-page-view' => 'd2a6518d', 748 748 'phabricator-textareautils' => '5c93c52c', 749 - 'phabricator-title' => '5c1c758c', 749 + 'phabricator-title' => 'df5e11d2', 750 750 'phabricator-tooltip' => '1d298e3a', 751 751 'phabricator-transaction-view-css' => 'bd9f9f6e', 752 752 'phabricator-ui-example-css' => '528b19de', ··· 1215 1215 'javelin-uri', 1216 1216 'javelin-routable', 1217 1217 ), 1218 - '5c1c758c' => array( 1219 - 'javelin-install', 1220 - ), 1221 1218 '5c54cbf3' => array( 1222 1219 'javelin-behavior', 1223 1220 'javelin-stratcom', ··· 1760 1757 'javelin-stratcom', 1761 1758 'phabricator-phtize', 1762 1759 ), 1763 - 'cda6de80' => array( 1764 - 'javelin-behavior', 1765 - 'javelin-dom', 1766 - 'javelin-util', 1767 - 'javelin-stratcom', 1768 - 'javelin-workflow', 1769 - 'javelin-behavior-device', 1770 - 'javelin-history', 1771 - 'javelin-vector', 1772 - 'phabricator-shaped-request', 1773 - 'conpherence-thread-manager', 1774 - ), 1775 1760 'd19198c8' => array( 1776 1761 'javelin-install', 1777 1762 'javelin-dom', ··· 1811 1796 'javelin-util', 1812 1797 'phabricator-shaped-request', 1813 1798 ), 1799 + 'db6c0ba7' => array( 1800 + 'javelin-behavior', 1801 + 'javelin-dom', 1802 + 'javelin-util', 1803 + 'javelin-stratcom', 1804 + 'javelin-workflow', 1805 + 'javelin-behavior-device', 1806 + 'javelin-history', 1807 + 'javelin-vector', 1808 + 'phabricator-title', 1809 + 'phabricator-shaped-request', 1810 + 'conpherence-thread-manager', 1811 + ), 1814 1812 'dbbf48b6' => array( 1815 1813 'javelin-behavior', 1816 1814 'javelin-stratcom', ··· 1823 1821 'javelin-typeahead', 1824 1822 'javelin-typeahead-ondemand-source', 1825 1823 'javelin-dom', 1824 + ), 1825 + 'df5e11d2' => array( 1826 + 'javelin-install', 1826 1827 ), 1827 1828 'e10f8e18' => array( 1828 1829 'javelin-behavior',
+3 -2
webroot/rsrc/js/application/conpherence/behavior-menu.js
··· 8 8 * javelin-behavior-device 9 9 * javelin-history 10 10 * javelin-vector 11 + * phabricator-title 11 12 * phabricator-shaped-request 12 13 * conpherence-thread-manager 13 14 */ ··· 151 152 } 152 153 JX.History.replace(config.baseURI + uri_suffix); 153 154 if (data.title) { 154 - document.title = data.title; 155 + JX.Title.setTitle(data.title); 155 156 } else if (_thread.node) { 156 157 var threadData = JX.Stratcom.getData(_thread.node); 157 - document.title = threadData.title; 158 + JX.Title.setTitle(threadData.title); 158 159 } 159 160 } 160 161
+6
webroot/rsrc/js/core/Title.js
··· 18 18 self._update(); 19 19 }, 20 20 21 + setTitle: function(title) { 22 + var self = JX.Title; 23 + self._title = title; 24 + self._update(); 25 + }, 26 + 21 27 _update: function() { 22 28 var self = JX.Title; 23 29