@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make DiffusionQuery extend PhabricatorQuery
Summary: Ref T2683. Provides access to `formatWhereClause()`, etc. I plan to eventually unify the various DiffusionQuery execute methods as well, which all have special names right now (`loadModifiedPaths()`, `loadWhateverBlah()`, etc).
Test Plan: Ran EverythingImplemented test. Browsed Diffusion.
Reviewers: vrana
Reviewed By: vrana
CC: aran
Maniphest Tasks: T2683
Differential Revision: https://secure.phabricator.com/D5251
+6
-1
+1
src/__phutil_library_map__.php
+1
src/__phutil_library_map__.php
···
2224
2224
'DiffusionPathQueryTestCase' => 'PhabricatorTestCase',
2225
2225
'DiffusionPathValidateController' => 'DiffusionController',
2226
2226
'DiffusionPeopleMenuEventListener' => 'PhutilEventListener',
2227
+
'DiffusionQuery' => 'PhabricatorQuery',
2227
2228
'DiffusionRawDiffQuery' => 'DiffusionQuery',
2228
2229
'DiffusionRemarkupRule' => 'PhabricatorRemarkupRuleObject',
2229
2230
'DiffusionRepositoryController' => 'DiffusionController',
+5
-1
src/applications/diffusion/query/DiffusionQuery.php
+5
-1
src/applications/diffusion/query/DiffusionQuery.php
···
1
1
<?php
2
2
3
-
abstract class DiffusionQuery {
3
+
abstract class DiffusionQuery extends PhabricatorQuery {
4
4
5
5
private $request;
6
6
···
34
34
35
35
final protected function getRequest() {
36
36
return $this->request;
37
+
}
38
+
39
+
public function execute() {
40
+
return $this->executeQuery();
37
41
}
38
42
39
43
abstract protected function executeQuery();