recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Simplify implementation of "SysetemAction->getSystemActionConstant()"

Summary: Depends on D20668. Ref T13343. Just an easy cleanup/simplification while I'm here.

Test Plan: `grep` for `getActionConstant()`

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13343

Differential Revision: https://secure.phabricator.com/D20669

epriestley 2ee5e710 a75766c0

+5 -48
-4
src/applications/auth/action/PhabricatorAuthChangePasswordAction.php
··· 5 5 6 6 const TYPECONST = 'auth.password'; 7 7 8 - public function getActionConstant() { 9 - return self::TYPECONST; 10 - } 11 - 12 8 public function getScoreThreshold() { 13 9 return 20 / phutil_units('1 hour in seconds'); 14 10 }
-4
src/applications/auth/action/PhabricatorAuthEmailLoginAction.php
··· 4 4 5 5 const TYPECONST = 'mail.login'; 6 6 7 - public function getActionConstant() { 8 - return self::TYPECONST; 9 - } 10 - 11 7 public function getScoreThreshold() { 12 8 return 3 / phutil_units('1 hour in seconds'); 13 9 }
-4
src/applications/auth/action/PhabricatorAuthNewFactorAction.php
··· 4 4 5 5 const TYPECONST = 'auth.factor.new'; 6 6 7 - public function getActionConstant() { 8 - return self::TYPECONST; 9 - } 10 - 11 7 public function getScoreThreshold() { 12 8 return 60 / phutil_units('1 hour in seconds'); 13 9 }
-4
src/applications/auth/action/PhabricatorAuthTestSMSAction.php
··· 4 4 5 5 const TYPECONST = 'auth.sms.test'; 6 6 7 - public function getActionConstant() { 8 - return self::TYPECONST; 9 - } 10 - 11 7 public function getScoreThreshold() { 12 8 return 60 / phutil_units('1 hour in seconds'); 13 9 }
-4
src/applications/auth/action/PhabricatorAuthTryEmailLoginAction.php
··· 5 5 6 6 const TYPECONST = 'mail.try-login'; 7 7 8 - public function getActionConstant() { 9 - return self::TYPECONST; 10 - } 11 - 12 8 public function getScoreThreshold() { 13 9 return 20 / phutil_units('1 hour in seconds'); 14 10 }
-4
src/applications/auth/action/PhabricatorAuthTryFactorAction.php
··· 4 4 5 5 const TYPECONST = 'auth.factor'; 6 6 7 - public function getActionConstant() { 8 - return self::TYPECONST; 9 - } 10 - 11 7 public function getScoreThreshold() { 12 8 return 10 / phutil_units('1 hour in seconds'); 13 9 }
-4
src/applications/auth/action/PhabricatorAuthTryPasswordAction.php
··· 5 5 6 6 const TYPECONST = 'auth.password'; 7 7 8 - public function getActionConstant() { 9 - return self::TYPECONST; 10 - } 11 - 12 8 public function getScoreThreshold() { 13 9 return 100 / phutil_units('1 hour in seconds'); 14 10 }
-4
src/applications/auth/action/PhabricatorAuthTryPasswordWithoutCAPTCHAAction.php
··· 5 5 6 6 const TYPECONST = 'auth.password-without-captcha'; 7 7 8 - public function getActionConstant() { 9 - return self::TYPECONST; 10 - } 11 - 12 8 public function getScoreThreshold() { 13 9 return 10 / phutil_units('1 hour in seconds'); 14 10 }
-4
src/applications/files/action/PhabricatorFilesOutboundRequestAction.php
··· 5 5 6 6 const TYPECONST = 'files.outbound'; 7 7 8 - public function getActionConstant() { 9 - return self::TYPECONST; 10 - } 11 - 12 8 public function getScoreThreshold() { 13 9 return 60 / phutil_units('1 hour in seconds'); 14 10 }
+1 -3
src/applications/metamta/action/PhabricatorMetaMTAErrorMailAction.php
··· 2 2 3 3 final class PhabricatorMetaMTAErrorMailAction extends PhabricatorSystemAction { 4 4 5 - public function getActionConstant() { 6 - return 'email.error'; 7 - } 5 + const TYPECONST = 'email.error'; 8 6 9 7 public function getScoreThreshold() { 10 8 return 6 / phutil_units('1 hour in seconds');
-4
src/applications/phortune/action/PhortuneAddPaymentMethodAction.php
··· 5 5 6 6 const TYPECONST = 'phortune.payment-method.add'; 7 7 8 - public function getActionConstant() { 9 - return self::TYPECONST; 10 - } 11 - 12 8 public function getScoreThreshold() { 13 9 return 60 / phutil_units('1 hour in seconds'); 14 10 }
-4
src/applications/settings/action/PhabricatorSettingsAddEmailAction.php
··· 4 4 5 5 const TYPECONST = 'email.add'; 6 6 7 - public function getActionConstant() { 8 - return self::TYPECONST; 9 - } 10 - 11 7 public function getScoreThreshold() { 12 8 return 6 / phutil_units('1 hour in seconds'); 13 9 }
+4 -1
src/applications/system/action/PhabricatorSystemAction.php
··· 2 2 3 3 abstract class PhabricatorSystemAction extends Phobject { 4 4 5 - abstract public function getActionConstant(); 5 + final public function getActionConstant() { 6 + return $this->getPhobjectClassConstant('TYPECONST', 32); 7 + } 8 + 6 9 abstract public function getScoreThreshold(); 7 10 8 11 public function shouldBlockActor($actor, $score) {