@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove bottom margin from embedded remarkup images
Summary:
{T15473} created a very small but annoying regression. Every embedded images has now an margin at the bottom:
{F718091}
I don't think this is intentional. If you click on the margin the image itself is opened not the lightbox. This revision removes the margin.
Test Plan: Look at tasks with embedded images and see if there is still an margin.
Reviewers: O1 Blessed Committers, valerio.bozzolan, aklapper
Reviewed By: O1 Blessed Committers, valerio.bozzolan, aklapper
Subscribers: aklapper, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25522
+15
-10
+5
-5
resources/celerity/map.php
+5
-5
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '2f25eb4f',
11
11
'conpherence.pkg.js' => '020aebcf',
12
-
'core.pkg.css' => '5e7dbeb9',
12
+
'core.pkg.css' => '3b2df0d0',
13
13
'core.pkg.js' => '2eeda9e0',
14
14
'dark-console.pkg.js' => '187792c2',
15
15
'differential.pkg.css' => '2431def2',
···
109
109
'rsrc/css/application/tokens/tokens.css' => 'ce5a50bd',
110
110
'rsrc/css/application/uiexample/example.css' => 'b4795059',
111
111
'rsrc/css/core/core.css' => 'b3a5928e',
112
-
'rsrc/css/core/remarkup.css' => '3480e1fe',
112
+
'rsrc/css/core/remarkup.css' => 'b251d2e7',
113
113
'rsrc/css/core/syntax.css' => '548567f6',
114
114
'rsrc/css/core/z-index.css' => 'ac3bfcd4',
115
115
'rsrc/css/diviner/diviner-shared.css' => '4bd263b0',
···
171
171
'rsrc/css/phui/phui-pager.css' => 'd022c7ad',
172
172
'rsrc/css/phui/phui-pinboard-view.css' => '1f08f5d8',
173
173
'rsrc/css/phui/phui-policy-section-view.css' => '139fdc64',
174
-
'rsrc/css/phui/phui-property-list-view.css' => '118db252',
174
+
'rsrc/css/phui/phui-property-list-view.css' => '9a155095',
175
175
'rsrc/css/phui/phui-remarkup-preview.css' => '91767007',
176
176
'rsrc/css/phui/phui-segment-bar-view.css' => '5166b370',
177
177
'rsrc/css/phui/phui-spacing.css' => 'b05cadc3',
···
798
798
'phabricator-object-selector-css' => 'ee77366f',
799
799
'phabricator-phtize' => '2f1db1ed',
800
800
'phabricator-prefab' => '5793d835',
801
-
'phabricator-remarkup-css' => '3480e1fe',
801
+
'phabricator-remarkup-css' => 'b251d2e7',
802
802
'phabricator-remarkup-metadata' => 'e40c4991',
803
803
'phabricator-search-results-css' => '9ea70ace',
804
804
'phabricator-shaped-request' => '995f5102',
···
873
873
'phui-pager-css' => 'd022c7ad',
874
874
'phui-pinboard-view-css' => '1f08f5d8',
875
875
'phui-policy-section-view-css' => '139fdc64',
876
-
'phui-property-list-view-css' => '118db252',
876
+
'phui-property-list-view-css' => '9a155095',
877
877
'phui-remarkup-preview-css' => '91767007',
878
878
'phui-segment-bar-view-css' => '5166b370',
879
879
'phui-spacing-css' => 'b05cadc3',
+8
webroot/rsrc/css/core/remarkup.css
+8
webroot/rsrc/css/core/remarkup.css
···
474
474
box-shadow: 1px 1px 2px rgba({$alphablack}, 0.20);
475
475
}
476
476
477
+
.phabricator-remarkup-embed-image > img {
478
+
background: url('/rsrc/image/checker_light.png');
479
+
}
480
+
481
+
.device-desktop .phabricator-remarkup-embed-image > img:hover {
482
+
background: url('/rsrc/image/checker_dark.png');
483
+
}
484
+
477
485
.phabricator-remarkup-embed-image-full,
478
486
.phabricator-remarkup-embed-image-wide {
479
487
display: inline-block;
+2
-5
webroot/rsrc/css/phui/phui-property-list-view.css
+2
-5
webroot/rsrc/css/phui/phui-property-list-view.css
···
203
203
border-bottom: 1px solid {$blueborder};
204
204
}
205
205
206
-
207
-
.document-engine-image img,
208
-
.phabricator-remarkup-embed-image img {
206
+
.document-engine-image img {
209
207
margin: 20px auto;
210
208
background: url('/rsrc/image/checker_light.png');
211
209
max-width: 100%;
212
210
}
213
211
214
-
.device-desktop .document-engine-image img:hover,
215
-
.device-desktop .phabricator-remarkup-embed-image img:hover {
212
+
.device-desktop .document-engine-image img:hover {
216
213
background: url('/rsrc/image/checker_dark.png');
217
214
}
218
215