@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

More Pholio CSS updates

Summary: Pholio CSS tweaks and fixes, many little nudges

Test Plan:
Reload Pholio Mock page

{F167109}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9566

+52 -66
+24 -24
resources/celerity/map.php
··· 7 7 return array( 8 8 'names' => 9 9 array( 10 - 'core.pkg.css' => 'a8d8a51c', 10 + 'core.pkg.css' => '8feeb38a', 11 11 'core.pkg.js' => '07b01d4f', 12 12 'darkconsole.pkg.js' => 'ca8671ce', 13 13 'differential.pkg.css' => '4a93db37', ··· 32 32 'rsrc/css/aphront/table-view.css' => 'b22b7216', 33 33 'rsrc/css/aphront/tokenizer.css' => '82ce2142', 34 34 'rsrc/css/aphront/tooltip.css' => '9c90229d', 35 - 'rsrc/css/aphront/transaction.css' => 'ce491938', 35 + 'rsrc/css/aphront/transaction.css' => '3fe49ff1', 36 36 'rsrc/css/aphront/two-column.css' => '16ab3ad2', 37 37 'rsrc/css/aphront/typeahead.css' => 'a989b5b3', 38 38 'rsrc/css/application/auth/auth.css' => '1e655982', ··· 80 80 'rsrc/css/application/people/people-profile.css' => 'ba7b2762', 81 81 'rsrc/css/application/phame/phame.css' => '19ecc703', 82 82 'rsrc/css/application/pholio/pholio-edit.css' => '3ad9d1ee', 83 - 'rsrc/css/application/pholio/pholio-inline-comments.css' => '3d5a5590', 84 - 'rsrc/css/application/pholio/pholio.css' => 'e94312dd', 83 + 'rsrc/css/application/pholio/pholio-inline-comments.css' => '95004a57', 84 + 'rsrc/css/application/pholio/pholio.css' => 'faffc9f3', 85 85 'rsrc/css/application/phortune/phortune-credit-card-form.css' => 'b25b4beb', 86 86 'rsrc/css/application/phrequent/phrequent.css' => 'ffc185ad', 87 87 'rsrc/css/application/phriction/phriction-document-css.css' => '7d7f0071', ··· 398 398 'rsrc/js/application/passphrase/phame-credential-control.js' => '1e1c8a59', 399 399 'rsrc/js/application/phame/phame-post-preview.js' => '61d927ec', 400 400 'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => '1e1e8bb0', 401 - 'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '81f57c3a', 401 + 'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '4dd4ba6f', 402 402 'rsrc/js/application/phortune/behavior-balanced-payment-form.js' => '3b3e1664', 403 403 'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '1693a296', 404 404 'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'b3e5ee60', ··· 622 622 'javelin-behavior-phabricator-watch-anchor' => '06e05112', 623 623 'javelin-behavior-phame-post-preview' => '61d927ec', 624 624 'javelin-behavior-pholio-mock-edit' => '1e1e8bb0', 625 - 'javelin-behavior-pholio-mock-view' => '81f57c3a', 625 + 'javelin-behavior-pholio-mock-view' => '4dd4ba6f', 626 626 'javelin-behavior-phui-object-box-tabs' => 'a3e2244e', 627 627 'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3', 628 628 'javelin-behavior-policy-control' => 'f3fef818', ··· 734 734 'phabricator-standard-page-view' => '517cdfb1', 735 735 'phabricator-textareautils' => 'b3ec3cfc', 736 736 'phabricator-tooltip' => '3915d490', 737 - 'phabricator-transaction-view-css' => 'ce491938', 737 + 'phabricator-transaction-view-css' => '3fe49ff1', 738 738 'phabricator-ui-example-css' => '528b19de', 739 739 'phabricator-uiexample-javelin-view' => 'd4a14807', 740 740 'phabricator-uiexample-reactor-button' => '44524435', ··· 748 748 'phabricator-uiexample-reactor-sendproperties' => '551add57', 749 749 'phabricator-zindex-css' => 'efb673ac', 750 750 'phame-css' => '19ecc703', 751 - 'pholio-css' => 'e94312dd', 751 + 'pholio-css' => 'faffc9f3', 752 752 'pholio-edit-css' => '3ad9d1ee', 753 - 'pholio-inline-comments-css' => '3d5a5590', 753 + 'pholio-inline-comments-css' => '95004a57', 754 754 'phortune-credit-card-form' => '2290aeef', 755 755 'phortune-credit-card-form-css' => 'b25b4beb', 756 756 'phrequent-css' => 'ffc185ad', ··· 1181 1181 2 => 'javelin-dom', 1182 1182 3 => 'phuix-dropdown-menu', 1183 1183 ), 1184 + '4dd4ba6f' => 1185 + array( 1186 + 0 => 'javelin-behavior', 1187 + 1 => 'javelin-util', 1188 + 2 => 'javelin-stratcom', 1189 + 3 => 'javelin-dom', 1190 + 4 => 'javelin-vector', 1191 + 5 => 'javelin-magical-init', 1192 + 6 => 'javelin-request', 1193 + 7 => 'javelin-history', 1194 + 8 => 'javelin-workflow', 1195 + 9 => 'javelin-mask', 1196 + 10 => 'javelin-behavior-device', 1197 + 11 => 'phabricator-keyboard-shortcut', 1198 + ), 1184 1199 '4e37e4de' => 1185 1200 array( 1186 1201 0 => 'javelin-install', ··· 1420 1435 array( 1421 1436 0 => 'javelin-behavior', 1422 1437 1 => 'javelin-history', 1423 - ), 1424 - '81f57c3a' => 1425 - array( 1426 - 0 => 'javelin-behavior', 1427 - 1 => 'javelin-util', 1428 - 2 => 'javelin-stratcom', 1429 - 3 => 'javelin-dom', 1430 - 4 => 'javelin-vector', 1431 - 5 => 'javelin-magical-init', 1432 - 6 => 'javelin-request', 1433 - 7 => 'javelin-history', 1434 - 8 => 'javelin-workflow', 1435 - 9 => 'javelin-mask', 1436 - 10 => 'javelin-behavior-device', 1437 - 11 => 'phabricator-keyboard-shortcut', 1438 1438 ), 1439 1439 '82ce2142' => 1440 1440 array(
-1
src/applications/pholio/controller/PholioMockViewController.php
··· 122 122 $crumbs, 123 123 $object_box, 124 124 $output, 125 - phutil_tag('br'), 126 125 $thumb_grid, 127 126 $xaction_view, 128 127 $add_comment,
+3 -3
src/applications/pholio/view/PholioMockImagesView.php
··· 156 156 $inline_comments_holder = javelin_tag( 157 157 'div', 158 158 array( 159 - 'id' => 'mock-inline-comments', 160 - 'sigil' => 'mock-inline-comments', 161 - 'class' => 'pholio-mock-inline-comments' 159 + 'id' => 'mock-image-description', 160 + 'sigil' => 'mock-image-description', 161 + 'class' => 'mock-image-description' 162 162 ), 163 163 ''); 164 164
+3 -1
src/applications/pholio/view/PholioTransactionView.php
··· 64 64 } 65 65 66 66 if ($inlines) { 67 + $icon = id(new PHUIIconView()) 68 + ->setIconFont('fa-comment bluegrey msr'); 67 69 $header = phutil_tag( 68 70 'div', 69 71 array( 70 72 'class' => 'phabricator-transaction-subheader', 71 73 ), 72 - pht('Inline Comments')); 74 + array($icon, pht('Inline Comments'))); 73 75 74 76 $out[] = $header; 75 77 foreach ($inlines as $inline) {
+1
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
··· 261 261 return javelin_tag( 262 262 'span', 263 263 array( 264 + 'class' => 'transaction-comment', 264 265 'sigil' => 'transaction-comment', 265 266 'meta' => array('phid' => $comment->getTransactionPHID()), 266 267 ),
+4 -3
webroot/rsrc/css/aphront/transaction.css
··· 53 53 54 54 .phabricator-transaction-subheader { 55 55 color: {$lightgreytext}; 56 - border-bottom: 1px solid {$thinblueborder}; 57 - padding-bottom: 4px; 58 - margin-bottom: 8px; 56 + border-top: 1px solid {$thinblueborder}; 57 + padding-top: 12px; 58 + margin-top: 12px; 59 + padding-bottom: 8px; 59 60 } 60 61 61 62 div.phabricator-remarkup + .phabricator-transaction-subheader {
-24
webroot/rsrc/css/application/pholio/pholio-inline-comments.css
··· 2 2 * @provides pholio-inline-comments-css 3 3 */ 4 4 5 - .pholio-inline-comment { 6 - margin: 0 0 4px 0; 7 - padding: 8px; 8 - } 9 5 10 - .pholio-mock-inline-comments { 11 - background: #fff; 12 - border-top: 1px solid {$thinblueborder}; 13 - text-align: left; 14 - overflow: hidden; 15 - } 16 - 17 - .pholio-mock-inline-comments a { 18 - font-weight: normal; 19 - color: {$sky}; 20 - } 21 - 22 - .device-desktop .pholio-mock-inline-comment-highlight.pholio-mock-select-fill { 23 - opacity: 0.5; 24 - } 25 - 26 - .device-desktop .pholio-mock-inline-comment-highlight.pholio-inline-comment { 27 - background: #555555; 28 - border-color: #aaaaaa; 29 - }
+16 -9
webroot/rsrc/css/application/pholio/pholio.css
··· 97 97 padding-bottom: 2px; 98 98 } 99 99 100 - .pholio-transaction-inline-comment span { 100 + .pholio-transaction-inline-comment .transaction-comment { 101 101 display: table-cell; 102 102 vertical-align: middle; 103 103 padding-left: 8px; ··· 151 151 .pholio-image-title { 152 152 font-weight: bold; 153 153 color: {$bluetext}; 154 + font-size: 15px; 155 + } 156 + 157 + .mock-image-description { 158 + background: #fff; 159 + border-top: 1px solid {$thinblueborder}; 160 + text-align: left; 154 161 } 155 162 156 163 .pholio-mock-thumb-grid-comment-count { 157 164 position: absolute; 158 - right: 4px; 159 - bottom: 4px; 165 + top: -4px; 166 + right: -4px; 160 167 width: 20px; 161 - height: 20px; 162 - text-align: center; 163 - line-height: 20px; 164 - border-radius: 10px; 168 + height: 17px; 165 169 font-weight: bold; 170 + text-align: center; 171 + line-height: 16px; 172 + border-radius: 2px; 166 173 color: #fff; 167 174 text-decoration: none; 168 175 background: {$indigo}; ··· 202 209 } 203 210 204 211 .pholio-image-description { 205 - padding: 12px; 206 - border-top: 1px solid {$lightblueborder}; 212 + padding: 12px 8px; 213 + border-top: 1px solid {$thinblueborder}; 207 214 }
+1 -1
webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
··· 447 447 } 448 448 449 449 stage.clearStage(); 450 - var comment_holder = JX.$('mock-inline-comments'); 450 + var comment_holder = JX.$('mock-image-description'); 451 451 JX.DOM.setContent(comment_holder, render_image_info(active_image)); 452 452 453 453 var image_header = JX.$('mock-image-header');