@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Preserve linebreaks again in Summary / Test Plan for revisions
Summary:
I pulled these into the property list recently, which made them more consistent, but that dropped "preserve linebreaks". Since these usually come from the CLI, render with linebreaks preserved.
@csilvers, you'll need to `bin/cache purge --purge-remarkup` after this if you want to fix existing revisions.
Test Plan: Made a revision with some poetry, saw poetry preserved.
Reviewers: btrahan, csilvers
Reviewed By: btrahan
CC: csilvers, aran
Differential Revision: https://secure.phabricator.com/D7464
+6
-4
+6
-4
src/applications/differential/view/DifferentialRevisionDetailView.php
+6
-4
src/applications/differential/view/DifferentialRevisionDetailView.php
···
118
118
$properties->addSectionHeader(pht('Summary'));
119
119
$properties->addTextContent(
120
120
PhabricatorMarkupEngine::renderOneObject(
121
-
id(new PhabricatorMarkupOneOff())->setContent(
122
-
$revision->getSummary()),
121
+
id(new PhabricatorMarkupOneOff())
122
+
->setPreserveLinebreaks(true)
123
+
->setContent($revision->getSummary()),
123
124
'default',
124
125
$user));
125
126
}
···
128
129
$properties->addSectionHeader(pht('Test Plan'));
129
130
$properties->addTextContent(
130
131
PhabricatorMarkupEngine::renderOneObject(
131
-
id(new PhabricatorMarkupOneOff())->setContent(
132
-
$revision->getTestPlan()),
132
+
id(new PhabricatorMarkupOneOff())
133
+
->setPreserveLinebreaks(true)
134
+
->setContent($revision->getTestPlan()),
133
135
'default',
134
136
$user));
135
137
}