@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Oversight: Prevent deletion/movement of stub pages
Summary: Refs T2686 - Now you also can't delete / move stubbed pages
Test Plan: tried it out - works wonderful
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T2686
Differential Revision: https://secure.phabricator.com/D5341
authored by
Anh Nhan Nguyen
and committed by
epriestley
2f9c9817
76ed21d9
+2
+1
src/applications/phriction/controller/PhrictionDeleteController.php
+1
src/applications/phriction/controller/PhrictionDeleteController.php
···
25
25
$disallowed_states = array(
26
26
PhrictionDocumentStatus::STATUS_DELETED, // Stupid
27
27
PhrictionDocumentStatus::STATUS_MOVED, // Makes no sense
28
+
PhrictionDocumentStatus::STATUS_STUB, // How could they?
28
29
);
29
30
if (in_array($document->getStatus(), $disallowed_states)) {
30
31
$e_text = pht('An already moved or deleted document can not be deleted');
+1
src/applications/phriction/controller/PhrictionMoveController.php
+1
src/applications/phriction/controller/PhrictionMoveController.php
···
53
53
$disallowed_statuses = array(
54
54
PhrictionDocumentStatus::STATUS_DELETED, // Stupid
55
55
PhrictionDocumentStatus::STATUS_MOVED, // Plain stupid
56
+
PhrictionDocumentStatus::STATUS_STUB, // Utterly stupid
56
57
);
57
58
if (in_array($document->getStatus(), $disallowed_statuses)) {
58
59
$error_view = new AphrontErrorView();