@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use more reassuring UI and copy for removing payment methods
Summary:
The old treatment was fairly technical. Give this UI a more human-friendly flow:
- Use language "remove" instead of "disable". We keep the record that the card existed around for auditing/historical purposes, but it is no longer a valid payment method going forward and can not be undone. I think this aligns with user expectation and actual behavior better than "disable".
- Only show active methods on the profile screen.
Test Plan: {F1057153}
Reviewers: chad
Reviewed By: chad
Differential Revision: https://secure.phabricator.com/D14973
+8
-5
+4
src/applications/phortune/controller/PhortuneAccountViewController.php
+4
src/applications/phortune/controller/PhortuneAccountViewController.php
···
132
132
$methods = id(new PhortunePaymentMethodQuery())
133
133
->setViewer($viewer)
134
134
->withAccountPHIDs(array($account->getPHID()))
135
+
->withStatuses(
136
+
array(
137
+
PhortunePaymentMethod::STATUS_ACTIVE,
138
+
))
135
139
->execute();
136
140
137
141
foreach ($methods as $method) {
+4
-5
src/applications/phortune/controller/PhortunePaymentMethodDisableController.php
+4
-5
src/applications/phortune/controller/PhortunePaymentMethodDisableController.php
···
38
38
}
39
39
40
40
return $this->newDialog()
41
-
->setTitle(pht('Disable Payment Method?'))
42
-
->setShortTitle(pht('Disable Payment Method'))
41
+
->setTitle(pht('Remove Payment Method'))
43
42
->appendParagraph(
44
43
pht(
45
-
'Disable the payment method "%s"?',
44
+
'Remove the payment method "%s" from your account?',
46
45
phutil_tag(
47
46
'strong',
48
47
array(),
···
50
49
->appendParagraph(
51
50
pht(
52
51
'You will no longer be able to make payments using this payment '.
53
-
'method. Disabled payment methods can not be reactivated.'))
52
+
'method.'))
54
53
->addCancelButton($account_uri)
55
-
->addSubmitButton(pht('Disable Payment Method'));
54
+
->addSubmitButton(pht('Remove Payment Method'));
56
55
}
57
56
58
57
}