@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fourth fix for the magical world of crumbs and text-overflow
Summary: The Safari hack in place casued a truncation issue in Firefox, so that hack is now gone. Instead the bug appears to be the creative inclusion of "space". In fiddling with this adding one space inside the span and one space outside the span seems to resolve all cases.
Test Plan: Chrome, Safari, Firefox. Test "hector" and copy paste of a Task ID.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D17483
+8
-11
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'conpherence.pkg.css' => '6875302f',
11
11
'conpherence.pkg.js' => '6249a1cf',
12
-
'core.pkg.css' => '7e10ec60',
12
+
'core.pkg.css' => 'db710bcc',
13
13
'core.pkg.js' => '1fa7c0c5',
14
14
'darkconsole.pkg.js' => 'e7393ebb',
15
15
'differential.pkg.css' => '90b30783',
···
139
139
'rsrc/css/phui/phui-cms.css' => '504b4b23',
140
140
'rsrc/css/phui/phui-comment-form.css' => '48fbd65d',
141
141
'rsrc/css/phui/phui-comment-panel.css' => 'f50152ad',
142
-
'rsrc/css/phui/phui-crumbs-view.css' => 'ccbf2a0c',
142
+
'rsrc/css/phui/phui-crumbs-view.css' => '6ece3bbb',
143
143
'rsrc/css/phui/phui-curtain-view.css' => '947bf1a4',
144
144
'rsrc/css/phui/phui-document-pro.css' => 'f56738ed',
145
145
'rsrc/css/phui/phui-document-summary.css' => '9ca48bdf',
···
850
850
'phui-cms-css' => '504b4b23',
851
851
'phui-comment-form-css' => '48fbd65d',
852
852
'phui-comment-panel-css' => 'f50152ad',
853
-
'phui-crumbs-view-css' => 'ccbf2a0c',
853
+
'phui-crumbs-view-css' => '6ece3bbb',
854
854
'phui-curtain-view-css' => '947bf1a4',
855
855
'phui-document-summary-view-css' => '9ca48bdf',
856
856
'phui-document-view-css' => 'c32e8dec',
+5
-1
src/view/phui/PHUICrumbView.php
+5
-1
src/view/phui/PHUICrumbView.php
···
75
75
76
76
// Surround the crumb name with spaces so that double clicking it only
77
77
// selects the crumb itself.
78
-
$name = array(' ', $this->name, ' ');
78
+
$name = array(' ', $this->name);
79
79
80
80
$name = phutil_tag(
81
81
'span',
···
83
83
'class' => 'phui-crumb-name',
84
84
),
85
85
$name);
86
+
87
+
// Because of text-overflow and safari, put the second space on the
88
+
// outside of the element.
89
+
$name = array($name, ' ');
86
90
87
91
$divider = null;
88
92
if (!$this->isLastCrumb) {
-7
webroot/rsrc/css/phui/phui-crumbs-view.css
-7
webroot/rsrc/css/phui/phui-crumbs-view.css
···
54
54
text-overflow: ellipsis;
55
55
}
56
56
57
-
/* Safari Hack, See D17361 */
58
-
.phui-crumb-view:after {
59
-
content: "\0000a0";
60
-
display: inline-block;
61
-
width: 0;
62
-
}
63
-
64
57
.device-phone .phui-crumb-view.phabricator-last-crumb .phui-crumb-name,
65
58
.device-phone .phui-crumb-view.phui-crumb-has-icon,
66
59
.device-phone .phui-crumb-has-icon + .phui-crumb-divider {