recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Conduit docs: Clarify value type of points in maniphest.edit

Summary: Be less mysterious about the type of value required to edit `points` by explicitly setting `int|float`.

Test Plan:
* Go to http://phorge.localhost/conduit/method/maniphest.edit/#points and look at the Type for the Key `value`, see `int|float` instead of `points`
* See that `EXPLAIN phabricator_maniphest.maniphest_task` lists Type `double` for Field `points`
* Read https://www.php.net/manual/en/language.types.float.php to confirm that float and double are the same in PHP
* Use `maniphest.edit` Conduit API to set Points value of a task, still works

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26338

Andre Klapper 3006601e a796c015

+1 -1
+1 -1
src/applications/conduit/parametertype/ConduitPointsParameterType.php
··· 27 27 } 28 28 29 29 protected function getParameterTypeName() { 30 - return 'points'; 30 + return 'int|float'; 31 31 } 32 32 33 33 protected function getParameterFormatDescriptions() {