recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Normalize renderControl API

Summary: Make Maniphest use the standard API, `renderEditControl`. Removes custom method `renderControl`.

Test Plan: Created/edited tasks with custom fields.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7034

epriestley 30159d9a 45ff6077

+3 -11
+2 -2
src/applications/maniphest/auxiliaryfield/ManiphestAuxiliaryFieldDefaultSpecification.php
··· 108 108 return $this->checkboxValue; 109 109 } 110 110 111 - public function renderControl() { 111 + public function renderEditControl() { 112 112 $control = null; 113 113 114 114 $type = $this->getFieldType(); ··· 223 223 $type = $this->getFieldType(); 224 224 switch ($type) { 225 225 case self::TYPE_DATE: 226 - $control = $this->renderControl(); 226 + $control = $this->renderEditControl(); 227 227 $value = $control->readValueFromRequest($request); 228 228 break; 229 229 case self::TYPE_USER:
-4
src/applications/maniphest/auxiliaryfield/ManiphestAuxiliaryFieldSpecification.php
··· 80 80 return $this->type; 81 81 } 82 82 83 - public function renderControl() { 84 - return null; 85 - } 86 - 87 83 public function renderForDetailView() { 88 84 return $this->getValue(); 89 85 }
+1 -1
src/applications/maniphest/controller/ManiphestTaskEditController.php
··· 496 496 $aux_field->setError(true); 497 497 } 498 498 499 - $aux_control = $aux_field->renderControl(); 499 + $aux_control = $aux_field->renderEditControl(); 500 500 $form->appendChild($aux_control); 501 501 } 502 502
-4
src/applications/maniphest/field/ManiphestCustomField.php
··· 40 40 return false; 41 41 } 42 42 43 - public function renderControl() { 44 - return $this->renderEditControl(); 45 - } 46 - 47 43 public function validate() { 48 44 return true; 49 45 }