recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Prevent object titles in the "Object Attacher" dialog from triggering Quicksand "Close Dialog on Navigation" behavior

Summary:
Fixes T13363. Currently, these are genuine links which we intercept events for.

Make them pseudolinks instead. Possible alternative approaches are:

- Keep them as genuine links, but mark them as non-navigation links for Quicksand. (But: yuck, weird special case.)
- Keep them as genuine links, and have the dialog handler `JX.Stratcom.pass()` to see if anything handles the event. (But: the "pass()" pattern generally feels bad.)

"Tableaus" or whatever comes out of T10469 some day will probably break everything anyway?

Test Plan:
- Opened the "Edit Related Tasks... > Edit Subtasks" dialog.
- Clicked task title links (not the "open in new window" icon, and not the "Select" button).
- Before: Dialog (sometimes) closed abruptly.
- After: Task is consistently selected as part of the attachment set.

Maniphest Tasks: T13363

Differential Revision: https://secure.phabricator.com/D20693

epriestley 3069ef41 f5c380bf

+10 -10
+9 -9
resources/celerity/map.php
··· 12 12 'core.pkg.css' => 'af983028', 13 13 'core.pkg.js' => '73a06a9f', 14 14 'differential.pkg.css' => '8d8360fb', 15 - 'differential.pkg.js' => '67e02996', 15 + 'differential.pkg.js' => '0b037a4f', 16 16 'diffusion.pkg.css' => '42c75c37', 17 17 'diffusion.pkg.js' => 'a98c0bf7', 18 18 'maniphest.pkg.css' => '35995d6d', ··· 484 484 'rsrc/js/core/behavior-line-linker.js' => 'e15c8b1f', 485 485 'rsrc/js/core/behavior-linked-container.js' => '74446546', 486 486 'rsrc/js/core/behavior-more.js' => '506aa3f4', 487 - 'rsrc/js/core/behavior-object-selector.js' => 'a4af0b4a', 487 + 'rsrc/js/core/behavior-object-selector.js' => '98ef467f', 488 488 'rsrc/js/core/behavior-oncopy.js' => 'ff7b3f22', 489 489 'rsrc/js/core/behavior-phabricator-nav.js' => 'f166c949', 490 490 'rsrc/js/core/behavior-phabricator-remarkup-assist.js' => '2f80333f', ··· 645 645 'javelin-behavior-phabricator-line-linker' => 'e15c8b1f', 646 646 'javelin-behavior-phabricator-nav' => 'f166c949', 647 647 'javelin-behavior-phabricator-notification-example' => '29819b75', 648 - 'javelin-behavior-phabricator-object-selector' => 'a4af0b4a', 648 + 'javelin-behavior-phabricator-object-selector' => '98ef467f', 649 649 'javelin-behavior-phabricator-oncopy' => 'ff7b3f22', 650 650 'javelin-behavior-phabricator-remarkup-assist' => '2f80333f', 651 651 'javelin-behavior-phabricator-reveal-content' => 'b105a3a6', ··· 1730 1730 'javelin-dom', 1731 1731 'javelin-router', 1732 1732 ), 1733 + '98ef467f' => array( 1734 + 'javelin-behavior', 1735 + 'javelin-dom', 1736 + 'javelin-request', 1737 + 'javelin-util', 1738 + ), 1733 1739 '9aae2b66' => array( 1734 1740 'javelin-install', 1735 1741 'javelin-util', ··· 1789 1795 'a4aa75c4' => array( 1790 1796 'phui-button-css', 1791 1797 'phui-button-simple-css', 1792 - ), 1793 - 'a4af0b4a' => array( 1794 - 'javelin-behavior', 1795 - 'javelin-dom', 1796 - 'javelin-request', 1797 - 'javelin-util', 1798 1798 ), 1799 1799 'a5257c4e' => array( 1800 1800 'javelin-install',
+1 -1
webroot/rsrc/js/core/behavior-object-selector.js
··· 132 132 133 133 var select_object_link = JX.$N( 134 134 'a', 135 - {href: h.uri, sigil: 'object-attacher'}, 135 + {href: '#', sigil: 'object-attacher'}, 136 136 h.name); 137 137 138 138 var select_object_button = JX.$N(