@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Editing Audio in Macro/Meme: show caption with basic info
Summary:
It might be vaguely useful to know what happens to your audio
once you press save.
Screenshot after the change:
{F6759938}
Test Plan:
Visit a specific macro/meme from this link:
http://phorge.localhost/macro/
Click on Edit Audio. Enjoy the new caption.
Reviewers: O1 Blessed Committers, aklapper
Reviewed By: O1 Blessed Committers, aklapper
Subscribers: aklapper, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T16451
Differential Revision: https://we.phorge.it/D26723
+16
+16
src/applications/macro/controller/PhabricatorMacroAudioController.php
+16
src/applications/macro/controller/PhabricatorMacroAudioController.php
···
79
79
}
80
80
}
81
81
82
+
$suggestion_volume = pht(
83
+
'If you set one of the Play options, audio volume will automatically '.
84
+
'increase when scrolling closer to the Macro, and decrease when '.
85
+
'scrolling away.');
86
+
87
+
$suggestion_click = pht(
88
+
'If the audio does not play, you may need to reload the page and '.
89
+
'interact with it (for example, click somewhere), or check your web '.
90
+
'permissions as modern browsers may block audio autoplay.');
91
+
82
92
$form = id(new AphrontFormView())
83
93
->addHiddenInput('behaviorForm', 1)
84
94
->setUser($viewer);
···
107
117
pht(
108
118
'Play audio continuously, treating the macro as an audio source. '.
109
119
'Best for ambient sounds.'));
120
+
121
+
$options->setCaption(
122
+
implode(' ', array(
123
+
$suggestion_volume,
124
+
$suggestion_click,
125
+
)));
110
126
111
127
$form->appendChild($options);
112
128
$form->appendChild(