recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHP 8.5: Avoid null array key in Conduit's diffusion.commit.edit

Summary:
Setting null as an array key is deprecated since PHP 8.5 per https://www.php.net/releases/8.5/en.php: "Using null as an array offset or when calling array_key_exists() is now deprecated. Use an empty string instead."

```
ERROR 8192: Using null as an array offset is deprecated, use an empty string instead at [/var/www/html/phorge/phorge/src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php:35]
```

Closes T16437

Test Plan: On PHP 8.5, go to http://phorge.localhost/conduit/method/diffusion.commit.edit/

Reviewers: O1 Blessed Committers, mainframe98

Reviewed By: O1 Blessed Committers, mainframe98

Subscribers: mainframe98, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T16437

Differential Revision: https://we.phorge.it/D26648

Andre Klapper 30dd171c e713dae9

+1 -1
+1 -1
src/applications/diffusion/xaction/DiffusionCommitAuditTransaction.php
··· 32 32 33 33 $viewer_status = $this->getViewerAuditStatus($commit, $viewer); 34 34 35 - return isset($active[$viewer_status]); 35 + return $viewer_status !== null && isset($active[$viewer_status]); 36 36 } 37 37 38 38 protected function isViewerFullyAccepted(