@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix email for closing a blocking task
Summary: Fixes T5751. Currently, we incorrectly overwrite `$xactions`.
Test Plan: Closed a blocking task, got an email about the correct transaction set ("closed task; added comment") instead of an overwritten transaction set ("closed blocking task").
Reviewers: chad, btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T5751
Differential Revision: https://secure.phabricator.com/D10088
+3
-3
+3
-3
src/applications/maniphest/editor/ManiphestTransactionEditor.php
+3
-3
src/applications/maniphest/editor/ManiphestTransactionEditor.php
···
258
258
$new = $unblock_xaction->getNewValue();
259
259
260
260
foreach ($blocked_tasks as $blocked_task) {
261
-
$xactions = array();
261
+
$unblock_xactions = array();
262
262
263
-
$xactions[] = id(new ManiphestTransaction())
263
+
$unblock_xactions[] = id(new ManiphestTransaction())
264
264
->setTransactionType(ManiphestTransaction::TYPE_UNBLOCK)
265
265
->setOldValue(array($object->getPHID() => $old))
266
266
->setNewValue(array($object->getPHID() => $new));
···
275
275
->setContentSource($this->getContentSource())
276
276
->setContinueOnNoEffect(true)
277
277
->setContinueOnMissingFields(true)
278
-
->applyTransactions($blocked_task, $xactions);
278
+
->applyTransactions($blocked_task, $unblock_xactions);
279
279
}
280
280
}
281
281
}