recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Reorder audit actions to match Differential

Summary:
These trip me up every time because Differential has:

> Comment, Accept, Request Changes, Resign, Commandeer, Add Reviewers, Add Subscribers

while audits currently show:

> Comment, Add Subscribers, Add Auditors, Accept, Raise Concern, Resign

Now they're more or less in the same order which helps with muscle memory.

Test Plan: Careful inspection.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15323

authored by

Ben Alpert and committed by
epriestley 31927476 22d2b7ed

+3 -3
+3 -3
src/applications/diffusion/controller/DiffusionCommitController.php
··· 790 790 791 791 $actions = array(); 792 792 $actions[PhabricatorAuditActionConstants::COMMENT] = true; 793 - $actions[PhabricatorAuditActionConstants::ADD_CCS] = true; 794 - $actions[PhabricatorAuditActionConstants::ADD_AUDITORS] = true; 795 793 796 794 // We allow you to accept your own commits. A use case here is that you 797 795 // notice an issue with your own commit and "Raise Concern" as an indicator ··· 800 798 // however. 801 799 $actions[PhabricatorAuditActionConstants::ACCEPT] = true; 802 800 $actions[PhabricatorAuditActionConstants::CONCERN] = true; 803 - 804 801 805 802 // To resign, a user must have authority on some request and not be the 806 803 // commit's author. ··· 836 833 if ($can_close_option && $user_is_author && $concern_raised) { 837 834 $actions[PhabricatorAuditActionConstants::CLOSE] = true; 838 835 } 836 + 837 + $actions[PhabricatorAuditActionConstants::ADD_AUDITORS] = true; 838 + $actions[PhabricatorAuditActionConstants::ADD_CCS] = true; 839 839 840 840 foreach ($actions as $constant => $ignored) { 841 841 $actions[$constant] =