recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix comment box borders in timelines after Phriction commenting

Summary:
Ref T13202. In D19660, I added comments to Phriction and tweaked some CSS.

One of these tweaks was getting rid of an extra border which was rendering under the comment area. However, I took off too much and ended up removing borders from other applications.

I think we don't actually need this `setNoBorder()` stuff after all -- a later change was sufficient to stop the actual border I was trying to get rid of from rendering. So this mostly just reverts part of D19660.

This rendering still isn't perfect, but I'm fine leaving that for another day for now.

Test Plan:
- Viewed comment areas in Phriction. Saw correct number of borders (1).
- Viewed comment areas in Maniphest. Saw correct number of borders (1).
- Grepped for extraneous removed classs, no hits.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13202

Differential Revision: https://secure.phabricator.com/D19684

epriestley 3244324c 5ba66e56

+4 -12
+1 -1
src/applications/transactions/view/PhabricatorApplicationTransactionCommentView.php
··· 23 23 private $fullWidth; 24 24 private $infoView; 25 25 private $editEngineLock; 26 + private $noBorder; 26 27 27 28 private $currentVersion; 28 29 private $versionedDraft; ··· 243 244 244 245 $comment_box = id(new PHUIObjectBoxView()) 245 246 ->setFlush(true) 246 - ->setNoBorder(true) 247 247 ->addClass('phui-comment-form-view') 248 248 ->addSigil('phui-comment-form') 249 249 ->appendChild(
+1 -9
src/view/phui/PHUIObjectBoxView.php
··· 25 25 private $showHideHref; 26 26 private $showHideContent; 27 27 private $showHideOpen; 28 - private $noBorder; 29 28 30 29 private $propertyLists = array(); 31 30 ··· 148 147 return $this; 149 148 } 150 149 151 - public function setNoBorder($no_border) { 152 - $this->noBorder = $no_border; 153 - return $this; 154 - } 155 - 156 150 public function setValidationException( 157 151 PhabricatorApplicationTransactionValidationException $ex = null) { 158 152 $this->validationException = $ex; ··· 162 156 protected function getTagAttributes() { 163 157 $classes = array(); 164 158 $classes[] = 'phui-box'; 165 - if (!$this->noBorder) { 166 - $classes[] = 'phui-box-border'; 167 - } 159 + $classes[] = 'phui-box-border'; 168 160 $classes[] = 'phui-object-box'; 169 161 $classes[] = 'mlt mll mlr'; 170 162
+2 -2
src/view/phui/PHUITimelineEventView.php
··· 402 402 $wedge = phutil_tag( 403 403 'div', 404 404 array( 405 - 'class' => 'phui-timeline-wedge phui-timeline-border', 405 + 'class' => 'phui-timeline-wedge', 406 406 'style' => (nonempty($image_uri)) ? '' : 'display: none;', 407 407 ), 408 408 ''); ··· 461 461 $content = phutil_tag( 462 462 'div', 463 463 array( 464 - 'class' => 'phui-timeline-group phui-timeline-border', 464 + 'class' => 'phui-timeline-group', 465 465 ), 466 466 $content); 467 467